[PR #1589] [MERGED] video_core: clean-up of indirect draws logic #2185

New issue

Closed

opened 2026-02-27 21:15:30 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:15:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1589
Author: @psucien
Created: 11/24/2024
Status: ✅ Merged
Merged: 11/24/2024
Merged by: @psucien

Base: main ← Head: indirect_draw_cleanup

📝 Commits (1)

aab37fd video_core: clean-up of indirect draws logic

📊 Changes

5 files changed (+50 additions, -41 deletions)

View changed files

📝 src/core/libraries/gnmdriver/gnmdriver.cpp (+1 -1)
📝 src/video_core/amdgpu/liverpool.cpp (+4 -5)
📝 src/video_core/amdgpu/liverpool.h (+0 -2)
📝 src/video_core/amdgpu/pm4_cmds.h (+36 -21)
📝 src/video_core/renderer_vulkan/vk_rasterizer.cpp (+9 -12)

📄 Description

A bit of code cleanup, indexed and multiCount packets definitions separated (in accordance to GCN ref headers), fixed count buffer size calculation

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1589 **Author:** [@psucien](https://github.com/psucien) **Created:** 11/24/2024 **Status:** ✅ Merged **Merged:** 11/24/2024 **Merged by:** [@psucien](https://github.com/psucien) **Base:** `main` ← **Head:** `indirect_draw_cleanup` --- ### 📝 Commits (1) - [`aab37fd`](https://github.com/shadps4-emu/shadPS4/commit/aab37fd921fe4f0491b62fb30b653bc776ecb92d) video_core: clean-up of indirect draws logic ### 📊 Changes **5 files changed** (+50 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/gnmdriver/gnmdriver.cpp` (+1 -1) 📝 `src/video_core/amdgpu/liverpool.cpp` (+4 -5) 📝 `src/video_core/amdgpu/liverpool.h` (+0 -2) 📝 `src/video_core/amdgpu/pm4_cmds.h` (+36 -21) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.cpp` (+9 -12) </details> ### 📄 Description A bit of code cleanup, indexed and multiCount packets definitions separated (in accordance to GCN ref headers), fixed count buffer size calculation --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>