[PR #1476] [MERGED] qt: Error if installing DLC without game. #2129

New issue

Closed

opened 2026-02-27 21:15:18 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:15:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1476
Author: @squidbus
Created: 11/2/2024
Status: ✅ Merged
Merged: 11/2/2024
Merged by: @georgemoralis

Base: main ← Head: dlc-install

📝 Commits (1)

6135ddc qt: Error if installing DLC without game.

📊 Changes

1 file changed (+10 additions, -10 deletions)

View changed files

📝 src/qt_gui/main_window.cpp (+10 -10)

📄 Description

Currently if you try to install DLC without the game installed first, it will install it incorrectly as if it is a game, because the logic to check for updates and DLC only happens if the game directory exists.

The whole game vs update vs DLC package install code could use some cleaning up in general to address logic holes like this, but to at least prevent the issue for now, error if the user attempts to install DLC without the game installed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1476 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 11/2/2024 **Status:** ✅ Merged **Merged:** 11/2/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `dlc-install` --- ### 📝 Commits (1) - [`6135ddc`](https://github.com/shadps4-emu/shadPS4/commit/6135ddc7f7e0ed0f9d951cc41ecc1cd4e598d69e) qt: Error if installing DLC without game. ### 📊 Changes **1 file changed** (+10 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/qt_gui/main_window.cpp` (+10 -10) </details> ### 📄 Description Currently if you try to install DLC without the game installed first, it will install it incorrectly as if it is a game, because the logic to check for updates and DLC only happens if the game directory exists. The whole game vs update vs DLC package install code could use some cleaning up in general to address logic holes like this, but to at least prevent the issue for now, error if the user attempts to install DLC without the game installed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>