[PR #1481] [MERGED] Image binding and texture cache interface refactor (1/2) #2127

New issue

Closed

opened 2026-02-27 21:15:18 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:15:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1481
Author: @psucien
Created: 11/3/2024
Status: ✅ Merged
Merged: 11/24/2024
Merged by: @psucien

Base: main ← Head: enfant_terrible

📝 Commits (3)

f3935e7 video_core: texture_cache: interface refactor and better overlap handling
683849d resources binding moved into vk_rasterizer
7fd9b4b remove virtual flag leftover

📊 Changes

19 files changed (+902 additions, -670 deletions)

View changed files

📝 src/shader_recompiler/runtime_info.h (+1 -1)
📝 src/video_core/buffer_cache/buffer_cache.cpp (+4 -4)
📝 src/video_core/renderer_vulkan/vk_compute_pipeline.cpp (+4 -88)
📝 src/video_core/renderer_vulkan/vk_compute_pipeline.h (+0 -5)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp (+0 -67)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.h (+2 -10)
📝 src/video_core/renderer_vulkan/vk_pipeline_cache.h (+0 -2)
📝 src/video_core/renderer_vulkan/vk_pipeline_common.cpp (+28 -211)
📝 src/video_core/renderer_vulkan/vk_pipeline_common.h (+27 -12)
📝 src/video_core/renderer_vulkan/vk_presenter.h (+7 -5)
📝 src/video_core/renderer_vulkan/vk_rasterizer.cpp (+497 -94)
📝 src/video_core/renderer_vulkan/vk_rasterizer.h (+37 -1)
📝 src/video_core/texture_cache/image.cpp (+17 -5)
📝 src/video_core/texture_cache/image.h (+25 -3)
📝 src/video_core/texture_cache/image_info.cpp (+36 -35)
📝 src/video_core/texture_cache/image_info.h (+21 -13)
📝 src/video_core/texture_cache/image_view.cpp (+1 -1)
📝 src/video_core/texture_cache/texture_cache.cpp (+138 -103)
📝 src/video_core/texture_cache/texture_cache.h (+57 -10)

📄 Description

This brings better overlap management and fixes some of the previously observed issues in depth aliasing and mipgens. Known

Leftovers to address in Pt.2:

Image size calculation is still a bit off for small CB/DB surfaces
~~Missing MS macro tile params LUTs~~
Depth sub resources won't be merged, and whole image will be created instead
In case if a sub resource on right overlap is both a mip and a slice, only mip case will be handled
Views on particular slices aren't handled
Missing stencil registration

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1481 **Author:** [@psucien](https://github.com/psucien) **Created:** 11/3/2024 **Status:** ✅ Merged **Merged:** 11/24/2024 **Merged by:** [@psucien](https://github.com/psucien) **Base:** `main` ← **Head:** `enfant_terrible` --- ### 📝 Commits (3) - [`f3935e7`](https://github.com/shadps4-emu/shadPS4/commit/f3935e7126fdc7f0605037a8682e7a76fb4f8bc9) video_core: texture_cache: interface refactor and better overlap handling - [`683849d`](https://github.com/shadps4-emu/shadPS4/commit/683849d33bc74e6eda777a861aa5bd2073165fc4) resources binding moved into vk_rasterizer - [`7fd9b4b`](https://github.com/shadps4-emu/shadPS4/commit/7fd9b4b057c1aa38067be1c983bb06002108480a) remove `virtual` flag leftover ### 📊 Changes **19 files changed** (+902 additions, -670 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/runtime_info.h` (+1 -1) 📝 `src/video_core/buffer_cache/buffer_cache.cpp` (+4 -4) 📝 `src/video_core/renderer_vulkan/vk_compute_pipeline.cpp` (+4 -88) 📝 `src/video_core/renderer_vulkan/vk_compute_pipeline.h` (+0 -5) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp` (+0 -67) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.h` (+2 -10) 📝 `src/video_core/renderer_vulkan/vk_pipeline_cache.h` (+0 -2) 📝 `src/video_core/renderer_vulkan/vk_pipeline_common.cpp` (+28 -211) 📝 `src/video_core/renderer_vulkan/vk_pipeline_common.h` (+27 -12) 📝 `src/video_core/renderer_vulkan/vk_presenter.h` (+7 -5) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.cpp` (+497 -94) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.h` (+37 -1) 📝 `src/video_core/texture_cache/image.cpp` (+17 -5) 📝 `src/video_core/texture_cache/image.h` (+25 -3) 📝 `src/video_core/texture_cache/image_info.cpp` (+36 -35) 📝 `src/video_core/texture_cache/image_info.h` (+21 -13) 📝 `src/video_core/texture_cache/image_view.cpp` (+1 -1) 📝 `src/video_core/texture_cache/texture_cache.cpp` (+138 -103) 📝 `src/video_core/texture_cache/texture_cache.h` (+57 -10) </details> ### 📄 Description This brings better overlap management and fixes some of the previously observed issues in depth aliasing and mipgens. Known Leftovers to address in Pt.2: * Image size calculation is still a bit off for small CB/DB surfaces * ~Missing MS macro tile params LUTs~ * Depth sub resources won't be merged, and whole image will be created instead * In case if a sub resource on right overlap is both a mip and a slice, only mip case will be handled * Views on particular slices aren't handled * Missing stencil registration --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>