[PR #1388] [MERGED] AvPlayer: Do not align w/h to 16 with vdec2 #2081

New issue

Closed

opened 2026-02-27 21:15:06 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:15:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1388
Author: @roamic
Created: 10/15/2024
Status: ✅ Merged
Merged: 10/15/2024
Merged by: @georgemoralis

Base: main ← Head: av-player/fix-green-line

📝 Commits (1)

1a6bade AvPlayer: Do not align w/h to 16 with vdec2

📊 Changes

6 files changed (+54 additions, -23 deletions)

View changed files

📝 src/core/libraries/avplayer/avplayer_impl.cpp (+1 -1)
📝 src/core/libraries/avplayer/avplayer_impl.h (+0 -1)
📝 src/core/libraries/avplayer/avplayer_source.cpp (+42 -19)
📝 src/core/libraries/avplayer/avplayer_source.h (+2 -1)
📝 src/core/libraries/avplayer/avplayer_state.cpp (+7 -1)
📝 src/core/libraries/avplayer/avplayer_state.h (+2 -0)

📄 Description

Videodec2 seems to output unaligned frame data and some games rely on that behavior without checking crop offsets and/or frame height
Also reduced noise in the log when the game drains video data before draining audio

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1388 **Author:** [@roamic](https://github.com/roamic) **Created:** 10/15/2024 **Status:** ✅ Merged **Merged:** 10/15/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `av-player/fix-green-line` --- ### 📝 Commits (1) - [`1a6bade`](https://github.com/shadps4-emu/shadPS4/commit/1a6baded540c0f0e2409b9c204b5a804e3b3da47) AvPlayer: Do not align w/h to 16 with vdec2 ### 📊 Changes **6 files changed** (+54 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/avplayer/avplayer_impl.cpp` (+1 -1) 📝 `src/core/libraries/avplayer/avplayer_impl.h` (+0 -1) 📝 `src/core/libraries/avplayer/avplayer_source.cpp` (+42 -19) 📝 `src/core/libraries/avplayer/avplayer_source.h` (+2 -1) 📝 `src/core/libraries/avplayer/avplayer_state.cpp` (+7 -1) 📝 `src/core/libraries/avplayer/avplayer_state.h` (+2 -0) </details> ### 📄 Description * Videodec2 seems to output unaligned frame data and some games rely on that behavior without checking crop offsets and/or frame height * Also reduced noise in the log when the game drains video data before draining audio --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>