[PR #1331] [MERGED] shader_recompiler: Implement V_SUBB_U32 and V_SUBBREV_U32. #2051

New issue

Closed

opened 2026-02-27 21:14:59 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:14:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1331
Author: @squidbus
Created: 10/10/2024
Status: ✅ Merged
Merged: 10/10/2024
Merged by: @raphaelthegreat

Base: main ← Head: sub-inst

📝 Commits (1)

5291af5 shader_recompiler: Implement V_SUBB_U32 and V_SUBBREV_U32.

📊 Changes

2 files changed (+85 additions, -26 deletions)

View changed files

📝 src/shader_recompiler/frontend/translate/translate.h (+5 -1)
📝 src/shader_recompiler/frontend/translate/vector_alu.cpp (+80 -25)

📄 Description

Implement V_SUBB_U32 and V_SUBBREV_U32, used by CUSA16429.
Move carry in and out logic to helpers for supporting VOP2 and VOP3 forms.
Add missing carry out to V_SUB_I32 and V_SUBREV_I32.
Clarify in V_ADD_I32 and new instructions that carry out is TODO for instructions where inputs can be signed or unsigned.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1331 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 10/10/2024 **Status:** ✅ Merged **Merged:** 10/10/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `sub-inst` --- ### 📝 Commits (1) - [`5291af5`](https://github.com/shadps4-emu/shadPS4/commit/5291af5cedb20d69b2ff69c5af16b4ccb74bb57e) shader_recompiler: Implement V_SUBB_U32 and V_SUBBREV_U32. ### 📊 Changes **2 files changed** (+85 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/frontend/translate/translate.h` (+5 -1) 📝 `src/shader_recompiler/frontend/translate/vector_alu.cpp` (+80 -25) </details> ### 📄 Description * Implement `V_SUBB_U32` and `V_SUBBREV_U32`, used by CUSA16429. * Move carry in and out logic to helpers for supporting VOP2 and VOP3 forms. * Add missing carry out to `V_SUB_I32` and `V_SUBREV_I32`. * Clarify in `V_ADD_I32` and new instructions that carry out is TODO for instructions where inputs can be signed or unsigned. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>