[PR #1264] [CLOSED] load tooling info extension only when validation layers or renderdoc debugging is enabled #2026

New issue

Closed

opened 2026-02-27 21:14:53 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:14:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1264
Author: @voguelike
Created: 10/6/2024
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (1)

ff0a2b6 sophisticated fix for amd gpu + reshade instead of workaround

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 src/video_core/renderer_vulkan/vk_instance.cpp (+3 -1)

📄 Description

currently, VK_EXT_TOOLING_INFO_EXTENSION_NAME is loaded indiscriminately, causing amd gpu + reshade users to hang indefinitely when loading a game if vulkan validation layers are disabled. both the emulator and reshade function as intended when Vulkan validation layers are enabled.

to fix this, i added a simple check that only loads the tooling info if vulkan validation layers are enabled or if renderdoc debugging is enabled. since the tooling info extension is only used for debugging purposes (afaik), it doesn't need to be loaded during regular usage, which is the only occurrence where the emulator runs into a problem.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1264 **Author:** [@voguelike](https://github.com/voguelike) **Created:** 10/6/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`ff0a2b6`](https://github.com/shadps4-emu/shadPS4/commit/ff0a2b66ff330cbd41ef8a870a10c83fc8e4705e) sophisticated fix for amd gpu + reshade instead of workaround ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/vk_instance.cpp` (+3 -1) </details> ### 📄 Description currently, `VK_EXT_TOOLING_INFO_EXTENSION_NAME` is loaded indiscriminately, causing amd gpu + reshade users to hang indefinitely when loading a game if vulkan validation layers are disabled. both the emulator and reshade function as intended when Vulkan validation layers are enabled. to fix this, i added a simple check that only loads the tooling info if vulkan validation layers are enabled or if renderdoc debugging is enabled. since the tooling info extension is only used for debugging purposes (afaik), it doesn't need to be loaded during regular usage, which is the only occurrence where the emulator runs into a problem. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>