mirror of
https://github.com/shadps4-emu/shadPS4.git
synced 2026-04-26 00:05:58 +03:00
[PR #1257] [MERGED] Working touchpad support #2021
Labels
No labels
Bloodborne
bug
contributor wanted
documentation
enhancement
frontend
good first issue
help wanted
linux
pull-request
question
release
verification progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shadPS4#2021
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/shadps4-emu/shadPS4/pull/1257
Author: @fireph
Created: 10/6/2024
Status: ✅ Merged
Merged: 10/6/2024
Merged by: @georgemoralis
Base:
main← Head:touchpad-support-working📝 Commits (2)
ade79afWorking touchpad supportfb4a42cfix lint📊 Changes
1 file changed (+6 additions, -5 deletions)
View changed files
📝
src/core/libraries/pad/pad.cpp(+6 -5)📄 Description
Tested on a PS5 controller plugged in via USB on Windows 11. It appears to be working as one would expect, but there can be some weirdness when you press the touchpad really fast (it doesn't register the correct side of the touchpad in that case sometimes). I filed an issue with SDL since it is a bug within that project that causes this behavior https://github.com/libsdl-org/SDL/issues/11085.
I attempted to also get the back button on other controllers to trigger the left side of the touchpad, but haven't gotten a working version of that yet (and there would likely need to be a setting in shadPS4 to set whether the user wanted it to be left/right/center/none of the touchpad for the back button) so I'll leave that for a future PR (https://github.com/shadps4-emu/shadPS4/pull/1258).
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.