[PR #1250] [MERGED] vulkan: Fix two more validation errors. #2015

New issue

Closed

opened 2026-02-27 21:14:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:14:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1250
Author: @squidbus
Created: 10/5/2024
Status: ✅ Merged
Merged: 10/5/2024
Merged by: @georgemoralis

Base: main ← Head: valid-2

📝 Commits (1)

cef1724 vulkan: Fix two more validation errors.

📊 Changes

2 files changed (+8 additions, -2 deletions)

View changed files

📝 src/shader_recompiler/backend/spirv/spirv_emit_context.cpp (+3 -2)
📝 src/video_core/renderer_vulkan/vk_swapchain.cpp (+5 -0)

📄 Description

Small fixes to two more validation errors:

Fix SPIR-V error when sharp has size of 0, as array declaration needs to be at least size 1. Since size is 0 it should just be bound to null anyway.
Fix window resize destroying semaphores before commands referencing them have finished execution, by waiting for device to become idle before destroying.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1250 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 10/5/2024 **Status:** ✅ Merged **Merged:** 10/5/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `valid-2` --- ### 📝 Commits (1) - [`cef1724`](https://github.com/shadps4-emu/shadPS4/commit/cef172493c4a0cb4e8c12d72815819f198603ecd) vulkan: Fix two more validation errors. ### 📊 Changes **2 files changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/backend/spirv/spirv_emit_context.cpp` (+3 -2) 📝 `src/video_core/renderer_vulkan/vk_swapchain.cpp` (+5 -0) </details> ### 📄 Description Small fixes to two more validation errors: * Fix SPIR-V error when sharp has size of 0, as array declaration needs to be at least size 1. Since size is 0 it should just be bound to null anyway. * Fix window resize destroying semaphores before commands referencing them have finished execution, by waiting for device to become idle before destroying. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>