[PR #1242] [MERGED] Fix list sorting for some categories #2014

New issue

Closed

opened 2026-02-27 21:14:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:14:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1242
Author: @ElBread3
Created: 10/4/2024
Status: ✅ Merged
Merged: 10/5/2024
Merged by: @georgemoralis

Base: main ← Head: listsortfix

📝 Commits (3)

e04b4d1 fix list sorting for serial, firmware version, and game size
ae33b8c bad apple!!
037f10d qol

📊 Changes

2 files changed (+18 additions, -7 deletions)

View changed files

📝 src/qt_gui/game_grid_frame.cpp (+3 -1)
📝 src/qt_gui/game_list_frame.h (+15 -6)

📄 Description

When the sort all menu items PR was added I noticed the sorting being entirely out of order for some of the categories, so this should fix that. I've only confirmed they sort in the right order, so I'm not sure every category sorts in the right direction.

Additionally, I decided to add game info to the tool tip because I would always have to switch to list view from grid view just to see stuff like the game version, very annoying.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1242 **Author:** [@ElBread3](https://github.com/ElBread3) **Created:** 10/4/2024 **Status:** ✅ Merged **Merged:** 10/5/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `listsortfix` --- ### 📝 Commits (3) - [`e04b4d1`](https://github.com/shadps4-emu/shadPS4/commit/e04b4d1f9dd96de8b3e69344b88173f0a06244aa) fix list sorting for serial, firmware version, and game size - [`ae33b8c`](https://github.com/shadps4-emu/shadPS4/commit/ae33b8ccce3ea5bcb41563d8b89c5a12a62003ab) bad apple!! - [`037f10d`](https://github.com/shadps4-emu/shadPS4/commit/037f10d90d1036a28b4d620fb251ffbaa464a165) qol ### 📊 Changes **2 files changed** (+18 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/qt_gui/game_grid_frame.cpp` (+3 -1) 📝 `src/qt_gui/game_list_frame.h` (+15 -6) </details> ### 📄 Description When [the sort all menu items PR](https://github.com/shadps4-emu/shadPS4/pull/1183) was added I noticed the sorting being entirely out of order for some of the categories, so this should fix that. I've only confirmed they sort in the right order, so I'm not sure every category sorts in the right direction. Additionally, I decided to add game info to the tool tip because I would always have to switch to list view from grid view just to see stuff like the game version, very annoying. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>