[PR #1241] [MERGED] core/libraries: Videodec2 implementation #2011

New issue

Closed

opened 2026-02-27 21:14:49 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:14:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1241
Author: @polybiusproxy
Created: 10/4/2024
Status: ✅ Merged
Merged: 10/24/2024
Merged by: @polybiusproxy

Base: main ← Head: core/vdec2

📝 Commits (1)

4c1ae8a core/libraries: Videodec2 implementation

📊 Changes

12 files changed (+720 additions, -4 deletions)

View changed files

📝 CMakeLists.txt (+8 -0)
📝 src/common/logging/filter.cpp (+1 -0)
📝 src/common/logging/types.h (+1 -0)
📝 src/core/libraries/error_codes.h (+39 -1)
📝 src/core/libraries/fiber/fiber.cpp (+1 -1)
📝 src/core/libraries/libs.cpp (+2 -0)
➕ src/core/libraries/videodec/videodec2.cpp (+200 -0)
➕ src/core/libraries/videodec/videodec2.h (+139 -0)
➕ src/core/libraries/videodec/videodec2_avc.h (+60 -0)
➕ src/core/libraries/videodec/videodec2_impl.cpp (+228 -0)
➕ src/core/libraries/videodec/videodec2_impl.h (+39 -0)
📝 src/core/libraries/videoout/video_out.cpp (+2 -2)

📄 Description

Work-in-progress implementation of the Videodec2 library, used for AVC (H.264) and HEVC (H.265) video decoding.
Seen on games such as Persona 5 Royal and Rock Band 4.

Left tasks:

Error handling
Decoder flushing
Decoder reset
Obtaining picture info
HEVC/H.265 implementation
Implement memory querying

The memory querying functions are quite important, as the sizes we output can affect games - for example, if we give a low size for memory querying on Persona 5 Royal, the decode output breaks (see the first image below).
The decoder library outputs a different size depending on the decoder profile given by the game.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1241 **Author:** [@polybiusproxy](https://github.com/polybiusproxy) **Created:** 10/4/2024 **Status:** ✅ Merged **Merged:** 10/24/2024 **Merged by:** [@polybiusproxy](https://github.com/polybiusproxy) **Base:** `main` ← **Head:** `core/vdec2` --- ### 📝 Commits (1) - [`4c1ae8a`](https://github.com/shadps4-emu/shadPS4/commit/4c1ae8afac7055a23de9aa31c459bd693d1112f7) core/libraries: Videodec2 implementation ### 📊 Changes **12 files changed** (+720 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+8 -0) 📝 `src/common/logging/filter.cpp` (+1 -0) 📝 `src/common/logging/types.h` (+1 -0) 📝 `src/core/libraries/error_codes.h` (+39 -1) 📝 `src/core/libraries/fiber/fiber.cpp` (+1 -1) 📝 `src/core/libraries/libs.cpp` (+2 -0) ➕ `src/core/libraries/videodec/videodec2.cpp` (+200 -0) ➕ `src/core/libraries/videodec/videodec2.h` (+139 -0) ➕ `src/core/libraries/videodec/videodec2_avc.h` (+60 -0) ➕ `src/core/libraries/videodec/videodec2_impl.cpp` (+228 -0) ➕ `src/core/libraries/videodec/videodec2_impl.h` (+39 -0) 📝 `src/core/libraries/videoout/video_out.cpp` (+2 -2) </details> ### 📄 Description Work-in-progress implementation of the Videodec2 library, used for AVC (H.264) and HEVC (H.265) video decoding. Seen on games such as Persona 5 Royal and Rock Band 4. Left tasks: - [x] Error handling - [x] Decoder flushing - [x] Decoder reset - [x] Obtaining picture info - [ ] HEVC/H.265 implementation - [ ] Implement memory querying The memory querying functions are quite important, as the sizes we output can affect games - for example, if we give a low size for memory querying on Persona 5 Royal, the decode output breaks (see the first image below). The decoder library outputs a different size depending on the decoder profile given by the game. <p align="center"> <img src="https://github.com/user-attachments/assets/cda91d7b-83fe-4bc5-b940-faee6dd625e6" width="390"> <img src="https://github.com/user-attachments/assets/8fc41831-4f91-408d-a7a0-faeb63f792d4" width="390"> <img src="https://github.com/user-attachments/assets/e48cd893-ddba-4b65-a4cf-3aa474729c63" width="390"> <img src="https://github.com/user-attachments/assets/f77f5193-0ae7-4ca2-8476-f901888e738a" width="390"> </p> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>