[PR #1229] [MERGED] vulkan: Fix dynamic vertex binding stride validation errors. #2002

New issue

Closed

opened 2026-02-27 21:14:48 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:14:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1229
Author: @squidbus
Created: 10/4/2024
Status: ✅ Merged
Merged: 10/4/2024
Merged by: @georgemoralis

Base: main ← Head: stride-valid

📝 Commits (1)

ab2c89f vulkan: Fix dynamic vertex binding stride validation errors.

📊 Changes

2 files changed (+12 additions, -0 deletions)

View changed files

📝 src/video_core/buffer_cache/buffer_cache.cpp (+9 -0)
📝 src/video_core/renderer_vulkan/vk_instance.cpp (+3 -0)

📄 Description

Fix missing extendedDynamicState feature flag enable.
Fix case where empty vertex bindings leads to no bindVertexBuffers2EXT for a stride dynamic state pipeline in a command buffer, which is always required.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1229 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 10/4/2024 **Status:** ✅ Merged **Merged:** 10/4/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `stride-valid` --- ### 📝 Commits (1) - [`ab2c89f`](https://github.com/shadps4-emu/shadPS4/commit/ab2c89f7c55af5356bd7bb58ecd8474f9abc0198) vulkan: Fix dynamic vertex binding stride validation errors. ### 📊 Changes **2 files changed** (+12 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/buffer_cache/buffer_cache.cpp` (+9 -0) 📝 `src/video_core/renderer_vulkan/vk_instance.cpp` (+3 -0) </details> ### 📄 Description * Fix missing `extendedDynamicState` feature flag enable. * Fix case where empty vertex bindings leads to no `bindVertexBuffers2EXT` for a stride dynamic state pipeline in a command buffer, which is always required. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>