[PR #1212] [MERGED] audio_core: Fix return value types and shift some error handling to library. #1992

New issue

Closed

opened 2026-02-27 21:14:45 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:14:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1212
Author: @squidbus
Created: 10/3/2024
Status: ✅ Merged
Merged: 10/3/2024
Merged by: @georgemoralis

Base: main ← Head: audio-ret

📝 Commits (1)

d8815c6 audio_core: Fix return value types and shift some error handling to library.

📊 Changes

4 files changed (+32 additions, -38 deletions)

View changed files

📝 src/audio_core/sdl_audio.cpp (+7 -22)
📝 src/audio_core/sdl_audio.h (+4 -5)
📝 src/core/libraries/audio/audioout.cpp (+17 -11)
📝 src/core/libraries/audio/audioout.h (+4 -0)

📄 Description

https://github.com/shadps4-emu/shadPS4/pull/1200 changed some of the audio out functions to return error codes instead of bool without changing the return type. This finishes that up by changing the return types and fixing how the return values are handled on the library side.

This also shifts some of the error checking over to the library side, similar to how it is done currently with sceAudioOutOpen, to keep the back-end logic simpler in case there are more in the future.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1212 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 10/3/2024 **Status:** ✅ Merged **Merged:** 10/3/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `audio-ret` --- ### 📝 Commits (1) - [`d8815c6`](https://github.com/shadps4-emu/shadPS4/commit/d8815c6b659ba316ef0da295129edc2ee7283d4f) audio_core: Fix return value types and shift some error handling to library. ### 📊 Changes **4 files changed** (+32 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `src/audio_core/sdl_audio.cpp` (+7 -22) 📝 `src/audio_core/sdl_audio.h` (+4 -5) 📝 `src/core/libraries/audio/audioout.cpp` (+17 -11) 📝 `src/core/libraries/audio/audioout.h` (+4 -0) </details> ### 📄 Description https://github.com/shadps4-emu/shadPS4/pull/1200 changed some of the audio out functions to return error codes instead of bool without changing the return type. This finishes that up by changing the return types and fixing how the return values are handled on the library side. This also shifts some of the error checking over to the library side, similar to how it is done currently with `sceAudioOutOpen`, to keep the back-end logic simpler in case there are more in the future. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>