[PR #1199] [MERGED] shader_recompiler: Shader param fixups #1986

New issue

Closed

opened 2026-02-27 21:14:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:14:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1199
Author: @squidbus
Created: 10/2/2024
Status: ✅ Merged
Merged: 10/3/2024
Merged by: @georgemoralis

Base: main ← Head: params-fixup

📝 Commits (1)

2ec4a79 shader_recompiler: Shader param fixups

📊 Changes

3 files changed (+35 additions, -43 deletions)

View changed files

📝 src/shader_recompiler/backend/spirv/emit_spirv_context_get_set.cpp (+14 -28)
📝 src/shader_recompiler/backend/spirv/spirv_emit_context.cpp (+16 -11)
📝 src/shader_recompiler/backend/spirv/spirv_emit_context.h (+5 -4)

📄 Description

Use GetAttributeInfo to construct attribute infos more to simplify correct construction.
Allow passing num_components to GetAttributeInfo. Currently still always 4 but more correct this way.
Add asserts to make sure input parameters array is not overrun.
Fix missing boolean parameter and incorrect pointer type in one of the input attribute declarations.
Use existing constants for params and fragment outputs array sizes.
Misc style cleanup.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1199 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 10/2/2024 **Status:** ✅ Merged **Merged:** 10/3/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `params-fixup` --- ### 📝 Commits (1) - [`2ec4a79`](https://github.com/shadps4-emu/shadPS4/commit/2ec4a7909e3803e423dc582431c45cff17e01269) shader_recompiler: Shader param fixups ### 📊 Changes **3 files changed** (+35 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/backend/spirv/emit_spirv_context_get_set.cpp` (+14 -28) 📝 `src/shader_recompiler/backend/spirv/spirv_emit_context.cpp` (+16 -11) 📝 `src/shader_recompiler/backend/spirv/spirv_emit_context.h` (+5 -4) </details> ### 📄 Description * Use `GetAttributeInfo` to construct attribute infos more to simplify correct construction. * Allow passing `num_components` to `GetAttributeInfo`. Currently still always 4 but more correct this way. * Add asserts to make sure input parameters array is not overrun. * Fix missing boolean parameter and incorrect pointer type in one of the input attribute declarations. * Use existing constants for params and fragment outputs array sizes. * Misc style cleanup. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>