[PR #1197] [MERGED] replace trophy xml assert with error #1985

New issue

Closed

opened 2026-02-27 21:14:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:14:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1197
Author: @CrazyBloo
Created: 10/2/2024
Status: ✅ Merged
Merged: 10/2/2024
Merged by: @georgemoralis

Base: main ← Head: trophyassert

📝 Commits (1)

cf85c83 replace trophy xml error with assert

📊 Changes

1 file changed (+20 additions, -5 deletions)

View changed files

📝 src/core/libraries/np_trophy/np_trophy.cpp (+20 -5)

📄 Description

The assert when trophy functions failed to parse trophy xml data caused issues for users due to their games having encrypted npbind data, which would make the trophy decryption always fail.

edit: I will add a check for np encryption to the trophy parser, and have it decrypt the np data if its encrypted. it is probably good to merge this till that is done though

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1197 **Author:** [@CrazyBloo](https://github.com/CrazyBloo) **Created:** 10/2/2024 **Status:** ✅ Merged **Merged:** 10/2/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `trophyassert` --- ### 📝 Commits (1) - [`cf85c83`](https://github.com/shadps4-emu/shadPS4/commit/cf85c836a8d2e45e4648729a9564a3da22c9593d) replace trophy xml error with assert ### 📊 Changes **1 file changed** (+20 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/np_trophy/np_trophy.cpp` (+20 -5) </details> ### 📄 Description The assert when trophy functions failed to parse trophy xml data caused issues for users due to their games having encrypted npbind data, which would make the trophy decryption always fail. edit: I will add a check for np encryption to the trophy parser, and have it decrypt the np data if its encrypted. it is probably good to merge this till that is done though --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>