mirror of
https://github.com/shadps4-emu/shadPS4.git
synced 2026-04-26 16:25:58 +03:00
[PR #1196] [MERGED] core: Add support for Neo mode memory size. #1983
Labels
No labels
Bloodborne
bug
contributor wanted
documentation
enhancement
frontend
good first issue
help wanted
linux
pull-request
question
release
verification progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shadPS4#1983
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/shadps4-emu/shadPS4/pull/1196
Author: @squidbus
Created: 10/2/2024
Status: ✅ Merged
Merged: 10/8/2024
Merged by: @georgemoralis
Base:
main← Head:neo📝 Commits (1)
67ecb39core: Add support for Neo mode memory size.📊 Changes
4 files changed (+10 additions, -2 deletions)
View changed files
📝
src/core/address_space.cpp(+1 -1)📝
src/core/libraries/kernel/memory_management.h(+2 -0)📝
src/core/memory.cpp(+4 -1)📝
src/video_core/page_manager.cpp(+3 -0)📄 Description
Adds support for the larger PS4 Pro memory size when enabled. The value is not confirmed to be exact with hardware but aligns with expectations and at least gets games that utilize the extra memory running under Pro mode for now.
I also added an assert when the GPU page manager tries to track memory that is not mapped to the GPU, as I ran into a problem related to this while testing PS4 Pro mode. Currently when this happens it silently re-protects non-GPU memory, which can fail in confusing ways later as writes to that memory will be ignored by the signal handler and fail. Adding an assert makes it more obvious what happened.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.