[PR #1154] [MERGED] Fix path bugs & wrap seeks in an if #1958

New issue

Closed

opened 2026-02-27 21:14:37 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:14:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1154
Author: @OFFTKP
Created: 9/29/2024
Status: ✅ Merged
Merged: 9/30/2024
Merged by: @georgemoralis

Base: main ← Head: path

📝 Commits (2)

52b78ea Fix path bugs
1b86904 Wrap most seeks in an if

📊 Changes

11 files changed (+105 additions, -47 deletions)

View changed files

📝 src/common/io_file.cpp (+12 -0)
📝 src/core/file_format/pkg.cpp (+31 -8)
📝 src/core/file_format/pkg.h (+1 -1)
📝 src/core/file_format/trp.cpp (+21 -5)
📝 src/core/libraries/kernel/file_system.cpp (+12 -3)
📝 src/core/loader/elf.cpp (+12 -3)
📝 src/qt_gui/gui_context_menus.h (+1 -4)
📝 src/qt_gui/main_window.cpp (+7 -10)
📝 src/qt_gui/main_window.h (+1 -4)
📝 src/qt_gui/pkg_viewer.cpp (+6 -5)
📝 src/qt_gui/trophy_viewer.cpp (+1 -4)

📄 Description

These were doing both a conversion from string to path and then from wstring to path.

std::string to fs::path throws an exception on windows if the path has unicode symbols.

Wrapped IOFile::Seek calls in an if to better bug report bad seeks.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1154 **Author:** [@OFFTKP](https://github.com/OFFTKP) **Created:** 9/29/2024 **Status:** ✅ Merged **Merged:** 9/30/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `path` --- ### 📝 Commits (2) - [`52b78ea`](https://github.com/shadps4-emu/shadPS4/commit/52b78ea248e9cd4398eee16bc1d7ec440a438348) Fix path bugs - [`1b86904`](https://github.com/shadps4-emu/shadPS4/commit/1b86904e746a21ae275b99cb51cae96c30acc99b) Wrap most seeks in an if ### 📊 Changes **11 files changed** (+105 additions, -47 deletions) <details> <summary>View changed files</summary> 📝 `src/common/io_file.cpp` (+12 -0) 📝 `src/core/file_format/pkg.cpp` (+31 -8) 📝 `src/core/file_format/pkg.h` (+1 -1) 📝 `src/core/file_format/trp.cpp` (+21 -5) 📝 `src/core/libraries/kernel/file_system.cpp` (+12 -3) 📝 `src/core/loader/elf.cpp` (+12 -3) 📝 `src/qt_gui/gui_context_menus.h` (+1 -4) 📝 `src/qt_gui/main_window.cpp` (+7 -10) 📝 `src/qt_gui/main_window.h` (+1 -4) 📝 `src/qt_gui/pkg_viewer.cpp` (+6 -5) 📝 `src/qt_gui/trophy_viewer.cpp` (+1 -4) </details> ### 📄 Description These were doing both a conversion from string to path and then from wstring to path. std::string to fs::path throws an exception on windows if the path has unicode symbols. --- Wrapped IOFile::Seek calls in an `if` to better bug report bad seeks. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>