[PR #1160] [MERGED] sdl: Fix use of functions that now return SDL_bool #1957

Closed
opened 2026-02-27 21:14:37 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1160
Author: @squidbus
Created: 9/29/2024
Status: Merged
Merged: 9/30/2024
Merged by: @georgemoralis

Base: mainHead: sdl-fix


📝 Commits (1)

  • ea63377 sdl: Fix use of functions that now return SDL_bool

📊 Changes

3 files changed (+5 additions, -5 deletions)

View changed files

📝 src/audio_core/sdl_audio.cpp (+3 -3)
📝 src/input/controller.cpp (+1 -1)
📝 src/sdl_window.cpp (+1 -1)

📄 Description

Recent SDL update changed some functions to return SDL_bool instead of an integer return code. Adjust return value handling accordingly.

Fixes missing music audio in Project Diva Future Tone.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1160 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 9/29/2024 **Status:** ✅ Merged **Merged:** 9/30/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `sdl-fix` --- ### 📝 Commits (1) - [`ea63377`](https://github.com/shadps4-emu/shadPS4/commit/ea633777e324773af956c1386d9d3efe9d6c5787) sdl: Fix use of functions that now return SDL_bool ### 📊 Changes **3 files changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/audio_core/sdl_audio.cpp` (+3 -3) 📝 `src/input/controller.cpp` (+1 -1) 📝 `src/sdl_window.cpp` (+1 -1) </details> ### 📄 Description Recent SDL update changed some functions to return `SDL_bool` instead of an integer return code. Adjust return value handling accordingly. Fixes missing music audio in Project Diva Future Tone. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 21:14:37 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#1957
No description provided.