[PR #1146] [MERGED] Use correct scissor rects #1955

New issue

Closed

opened 2026-02-27 21:14:36 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:14:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1146
Author: @roamic
Created: 9/29/2024
Status: ✅ Merged
Merged: 10/1/2024
Merged by: @georgemoralis

Base: main ← Head: fix-bb-lighting

📝 Commits (6)

24a03ed WIP
fab50dc Proper combination of scissors
b0fa9da convert static functions to lambdas
72a07d0 Merge branch 'shadps4-emu:main' into fix-bb-lighting
de4eb75 Merge branch 'shadps4-emu:main' into fix-bb-lighting
f5002f8 Merge branch 'shadps4-emu:main' into fix-bb-lighting

📊 Changes

2 files changed (+89 additions, -18 deletions)

View changed files

📝 src/video_core/amdgpu/liverpool.h (+40 -13)
📝 src/video_core/renderer_vulkan/vk_rasterizer.cpp (+49 -5)

📄 Description

Fixes lightning issues in DS3 and BB.

Thanks @tGecko for finding the root cause.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1146 **Author:** [@roamic](https://github.com/roamic) **Created:** 9/29/2024 **Status:** ✅ Merged **Merged:** 10/1/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `fix-bb-lighting` --- ### 📝 Commits (6) - [`24a03ed`](https://github.com/shadps4-emu/shadPS4/commit/24a03edfb77ae6e7274ce2543492d389781cb8a5) WIP - [`fab50dc`](https://github.com/shadps4-emu/shadPS4/commit/fab50dcb005f79a30f1cbe5d86f1af2f72493044) Proper combination of scissors - [`b0fa9da`](https://github.com/shadps4-emu/shadPS4/commit/b0fa9da150e5c299e7a39ac140344b74129c0700) convert static functions to lambdas - [`72a07d0`](https://github.com/shadps4-emu/shadPS4/commit/72a07d0e16bf22ebfe1f407401ed84ea8ab904d5) Merge branch 'shadps4-emu:main' into fix-bb-lighting - [`de4eb75`](https://github.com/shadps4-emu/shadPS4/commit/de4eb75cf018764158afeafa750c9e944a0276f6) Merge branch 'shadps4-emu:main' into fix-bb-lighting - [`f5002f8`](https://github.com/shadps4-emu/shadPS4/commit/f5002f8010888bc6077c9612e99d22d38d548b3c) Merge branch 'shadps4-emu:main' into fix-bb-lighting ### 📊 Changes **2 files changed** (+89 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/amdgpu/liverpool.h` (+40 -13) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.cpp` (+49 -5) </details> ### 📄 Description Fixes lightning issues in DS3 and BB. Thanks @tGecko for finding the root cause. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>