[PR #1103] [CLOSED] Fix HLE Module loads #1933

New issue

Closed

opened 2026-02-27 21:14:31 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:14:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1103
Author: @StevenMiller123
Created: 9/27/2024
Status: ❌ Closed

Base: main ← Head: fix-rtc

📝 Commits (1)

9650a5e Update emulator.cpp

📊 Changes

1 file changed (+4 additions, -2 deletions)

View changed files

📝 src/emulator.cpp (+4 -2)

📄 Description

With the current code, if someone provides improperly dumped firmware modules, or corrupted firmware modules, the HLE module variant won't load. As we already return an error in linker->LoadModule when these issues occur, the only change needed is to make the LoadSystemModules function check for an error return.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1103 **Author:** [@StevenMiller123](https://github.com/StevenMiller123) **Created:** 9/27/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix-rtc` --- ### 📝 Commits (1) - [`9650a5e`](https://github.com/shadps4-emu/shadPS4/commit/9650a5e24e327187a939f9d5af8ed9922ca0d4f5) Update emulator.cpp ### 📊 Changes **1 file changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/emulator.cpp` (+4 -2) </details> ### 📄 Description With the current code, if someone provides improperly dumped firmware modules, or corrupted firmware modules, the HLE module variant won't load. As we already return an error in linker->LoadModule when these issues occur, the only change needed is to make the LoadSystemModules function check for an error return. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>