[PR #1101] [MERGED] vulkan: Fix some common validation errors. #1930

New issue

Closed

opened 2026-02-27 21:14:30 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:14:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1101
Author: @squidbus
Created: 9/27/2024
Status: ✅ Merged
Merged: 10/1/2024
Merged by: @raphaelthegreat

Base: main ← Head: validation

📝 Commits (3)

fbf1a26 vulkan: Fix some extension support related validation errors.
c719921 vulkan: Fix validation error on zero-size buffer.
c49bbeb vulkan: Fix primitive list restart validation error.

📊 Changes

6 files changed (+37 additions, -9 deletions)

View changed files

📝 src/shader_recompiler/backend/spirv/emit_spirv.cpp (+1 -0)
📝 src/video_core/buffer_cache/buffer.cpp (+3 -2)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp (+9 -3)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.h (+10 -0)
📝 src/video_core/renderer_vulkan/vk_instance.cpp (+3 -4)
📝 src/video_core/renderer_vulkan/vk_instance.h (+11 -0)

📄 Description

When VK_KHR_maintenance5 is not supported, fall back to the old logic of setting all flags on buffers since they cannot be added on to buffer views later.
Add extension SPV_EXT_demote_to_helper_invocation when using capability DemoteToHelperInvocationEXT for cases when the extension is being used with Vulkan 1.2.

These are the two most common causes of validation error spam when I'm testing on MoltenVK, which makes it hard to spot other more useful validation errors.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1101 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 9/27/2024 **Status:** ✅ Merged **Merged:** 10/1/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `validation` --- ### 📝 Commits (3) - [`fbf1a26`](https://github.com/shadps4-emu/shadPS4/commit/fbf1a267b0ddac3dd63bb2845ae68869fa0959f1) vulkan: Fix some extension support related validation errors. - [`c719921`](https://github.com/shadps4-emu/shadPS4/commit/c719921bbe0c4188c328d2babde03296edc87d01) vulkan: Fix validation error on zero-size buffer. - [`c49bbeb`](https://github.com/shadps4-emu/shadPS4/commit/c49bbebff8b16a71ac76de4cd022ef1e04936eb1) vulkan: Fix primitive list restart validation error. ### 📊 Changes **6 files changed** (+37 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/backend/spirv/emit_spirv.cpp` (+1 -0) 📝 `src/video_core/buffer_cache/buffer.cpp` (+3 -2) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp` (+9 -3) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.h` (+10 -0) 📝 `src/video_core/renderer_vulkan/vk_instance.cpp` (+3 -4) 📝 `src/video_core/renderer_vulkan/vk_instance.h` (+11 -0) </details> ### 📄 Description * When `VK_KHR_maintenance5` is not supported, fall back to the old logic of setting all flags on buffers since they cannot be added on to buffer views later. * Add extension `SPV_EXT_demote_to_helper_invocation` when using capability `DemoteToHelperInvocationEXT` for cases when the extension is being used with Vulkan 1.2. These are the two most common causes of validation error spam when I'm testing on MoltenVK, which makes it hard to spot other more useful validation errors. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>