[PR #1093] [MERGED] trophy icon + platinum fixes #1926

New issue

Closed

opened 2026-02-27 21:14:29 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:14:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1093
Author: @CrazyBloo
Created: 9/27/2024
Status: ✅ Merged
Merged: 10/1/2024
Merged by: @georgemoralis

Base: main ← Head: trophy3

📝 Commits (10+)

6798266 trophy icon + platinum fixes
c0c965c format
677d959 implement turtles review
54e4584 Merge branch 'main' into trophy3
358e63d use fs native where possible, clang format
2e2bfe8 implement vinicius suggestions
4970e4e format
8ef10bf final reviews
de3964a mutex for trophy queue, remove unneeded field
4bf774e format

📊 Changes

5 files changed (+359 additions, -422 deletions)

View changed files

📝 src/core/libraries/np_trophy/np_trophy.cpp (+254 -341)
📝 src/core/libraries/np_trophy/np_trophy.h (+29 -29)
📝 src/core/libraries/np_trophy/trophy_ui.cpp (+60 -40)
📝 src/core/libraries/np_trophy/trophy_ui.h (+15 -11)
📝 src/qt_gui/trophy_viewer.cpp (+1 -1)

📄 Description

This should be ready to merge

edit: I have reworked how trophy unlock state is saved, so trophy progress has been reset. If you want to keep your trophy progress go into shadps4/user/gamedata/(your game serial)/trophyfiles/xml/trop.xml and change all trophies with "unlocked" to "true"

Had to rework how platinum trophies are unlocked, the previous method would unlock the platinum early on some games.
Still need to add support for games with multiple platinum trophies, but none boot yet.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1093 **Author:** [@CrazyBloo](https://github.com/CrazyBloo) **Created:** 9/27/2024 **Status:** ✅ Merged **Merged:** 10/1/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `trophy3` --- ### 📝 Commits (10+) - [`6798266`](https://github.com/shadps4-emu/shadPS4/commit/679826623223dc39ff59d0816c2c048fe7f581d3) trophy icon + platinum fixes - [`c0c965c`](https://github.com/shadps4-emu/shadPS4/commit/c0c965cc7e4fcf1218de98fde468bd22ce3463bc) format - [`677d959`](https://github.com/shadps4-emu/shadPS4/commit/677d959b1e415a86c04d42cd5aed4cfaba07941c) implement turtles review - [`54e4584`](https://github.com/shadps4-emu/shadPS4/commit/54e458413aef5d9d4c380d13ba13ec08b200858b) Merge branch 'main' into trophy3 - [`358e63d`](https://github.com/shadps4-emu/shadPS4/commit/358e63d5e627e6f28cb85a1f9cacd1176f0e64a0) use fs native where possible, clang format - [`2e2bfe8`](https://github.com/shadps4-emu/shadPS4/commit/2e2bfe8db4e2ee826efcbcc730c2a4a44b1bb01f) implement vinicius suggestions - [`4970e4e`](https://github.com/shadps4-emu/shadPS4/commit/4970e4e34fcabe6d58645e2310397fd7d7573e53) format - [`8ef10bf`](https://github.com/shadps4-emu/shadPS4/commit/8ef10bf32a5d6e99a56adeecfe581bd1f6bb1aa4) final reviews - [`de3964a`](https://github.com/shadps4-emu/shadPS4/commit/de3964aded0b876910f244aead65fc38aa54b4b7) mutex for trophy queue, remove unneeded field - [`4bf774e`](https://github.com/shadps4-emu/shadPS4/commit/4bf774e46af0e964faf2b020dc995a26f19c964b) format ### 📊 Changes **5 files changed** (+359 additions, -422 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/np_trophy/np_trophy.cpp` (+254 -341) 📝 `src/core/libraries/np_trophy/np_trophy.h` (+29 -29) 📝 `src/core/libraries/np_trophy/trophy_ui.cpp` (+60 -40) 📝 `src/core/libraries/np_trophy/trophy_ui.h` (+15 -11) 📝 `src/qt_gui/trophy_viewer.cpp` (+1 -1) </details> ### 📄 Description This should be ready to merge edit: I have reworked how trophy unlock state is saved, so trophy progress has been reset. If you want to keep your trophy progress go into shadps4/user/gamedata/(your game serial)/trophyfiles/xml/trop.xml and change all trophies with "unlocked" to "true" Had to rework how platinum trophies are unlocked, the previous method would unlock the platinum early on some games. Still need to add support for games with multiple platinum trophies, but none boot yet. ![image](https://github.com/user-attachments/assets/ea950bb6-cf4a-4757-9d35-20b478a2d243) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>