mirror of
https://github.com/shadps4-emu/shadPS4.git
synced 2026-04-26 08:15:59 +03:00
[PR #1007] [MERGED] vulkan: Use closest available equivalent to missing clamp modes. #1877
Labels
No labels
Bloodborne
bug
contributor wanted
documentation
enhancement
frontend
good first issue
help wanted
linux
pull-request
question
release
verification progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shadPS4#1877
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/shadps4-emu/shadPS4/pull/1007
Author: @squidbus
Created: 9/21/2024
Status: ✅ Merged
Merged: 9/22/2024
Merged by: @raphaelthegreat
Base:
main← Head:clamp-mode📝 Commits (1)
1f59e36vulkan: Use closest available equivalent to missing clamp modes.📊 Changes
2 files changed (+10 additions, -0 deletions)
View changed files
📝
src/video_core/renderer_vulkan/liverpool_to_vk.cpp(+9 -0)📝
src/video_core/renderer_vulkan/vk_instance.cpp(+1 -0)📄 Description
Adding support for these clamp modes will likely require non-trivial sampler addressing emulation in shaders. For now, warn and use the closest available equivalent to enable games that use them to function.
Also set
samplerMirrorClampToEdgein the Vulkan 1.2 features since it is required for usingvk::SamplerAddressMode::eMirrorClampToEdge.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.