[PR #1007] [MERGED] vulkan: Use closest available equivalent to missing clamp modes. #1877

Closed
opened 2026-02-27 21:14:18 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1007
Author: @squidbus
Created: 9/21/2024
Status: Merged
Merged: 9/22/2024
Merged by: @raphaelthegreat

Base: mainHead: clamp-mode


📝 Commits (1)

  • 1f59e36 vulkan: Use closest available equivalent to missing clamp modes.

📊 Changes

2 files changed (+10 additions, -0 deletions)

View changed files

📝 src/video_core/renderer_vulkan/liverpool_to_vk.cpp (+9 -0)
📝 src/video_core/renderer_vulkan/vk_instance.cpp (+1 -0)

📄 Description

Adding support for these clamp modes will likely require non-trivial sampler addressing emulation in shaders. For now, warn and use the closest available equivalent to enable games that use them to function.

Also set samplerMirrorClampToEdge in the Vulkan 1.2 features since it is required for using vk::SamplerAddressMode::eMirrorClampToEdge.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1007 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 9/21/2024 **Status:** ✅ Merged **Merged:** 9/22/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `clamp-mode` --- ### 📝 Commits (1) - [`1f59e36`](https://github.com/shadps4-emu/shadPS4/commit/1f59e3663cd34f44c4fe72b44473ade12b7b8729) vulkan: Use closest available equivalent to missing clamp modes. ### 📊 Changes **2 files changed** (+10 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/liverpool_to_vk.cpp` (+9 -0) 📝 `src/video_core/renderer_vulkan/vk_instance.cpp` (+1 -0) </details> ### 📄 Description Adding support for these clamp modes will likely require non-trivial sampler addressing emulation in shaders. For now, warn and use the closest available equivalent to enable games that use them to function. Also set `samplerMirrorClampToEdge` in the Vulkan 1.2 features since it is required for using `vk::SamplerAddressMode::eMirrorClampToEdge`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 21:14:18 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#1877
No description provided.