[PR #1003] [MERGED] save_data: Fix save data list back button. #1875

New issue

Closed

opened 2026-02-27 21:14:17 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:14:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1003
Author: @squidbus
Created: 9/20/2024
Status: ✅ Merged
Merged: 9/21/2024
Merged by: @georgemoralis

Base: main ← Head: save-dialog-back

📝 Commits (2)

397c511 save_data: Fix save data list back button.
fecd596 common: Add more null checks in CString.

📊 Changes

2 files changed (+28 additions, -4 deletions)

View changed files

📝 src/common/cstring.h (+27 -3)
📝 src/core/libraries/save_data/dialog/savedatadialog_ui.cpp (+1 -1)

📄 Description

Fixes behavior of the save list dialog back button in CUSA16429. Before it would act as if a save was selected, now it returns to the game's menu.

Also added more null checks to CString to fix a potential crash (requested by @viniciuslrangel)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1003 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 9/20/2024 **Status:** ✅ Merged **Merged:** 9/21/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `save-dialog-back` --- ### 📝 Commits (2) - [`397c511`](https://github.com/shadps4-emu/shadPS4/commit/397c511c1d1e2595902320816cd4a5ac7c629b17) save_data: Fix save data list back button. - [`fecd596`](https://github.com/shadps4-emu/shadPS4/commit/fecd596e81d41681d37f9bc32800a0e7a032e3a1) common: Add more null checks in CString. ### 📊 Changes **2 files changed** (+28 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/common/cstring.h` (+27 -3) 📝 `src/core/libraries/save_data/dialog/savedatadialog_ui.cpp` (+1 -1) </details> ### 📄 Description Fixes behavior of the save list dialog back button in CUSA16429. Before it would act as if a save was selected, now it returns to the game's menu. Also added more null checks to CString to fix a potential crash (requested by @viniciuslrangel) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>