[PR #1001] [MERGED] vulkan: Add alternatives when nullDescriptor is not supported. #1873

New issue

Closed

opened 2026-02-27 21:14:17 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:14:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1001
Author: @squidbus
Created: 9/20/2024
Status: ✅ Merged
Merged: 9/21/2024
Merged by: @raphaelthegreat

Base: main ← Head: null-descriptor

📝 Commits (2)

c003b1a vulkan: Add alternatives when nullDescriptor is not supported.
3efddd7 vulkan: Set identifying name on null image/image view/buffer

📊 Changes

8 files changed (+46 additions, -6 deletions)

View changed files

📝 src/video_core/buffer_cache/buffer_cache.cpp (+5 -1)
📝 src/video_core/buffer_cache/buffer_cache.h (+5 -0)
📝 src/video_core/renderer_vulkan/vk_compute_pipeline.cpp (+5 -1)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp (+9 -2)
📝 src/video_core/renderer_vulkan/vk_instance.cpp (+4 -1)
📝 src/video_core/renderer_vulkan/vk_instance.h (+6 -0)
📝 src/video_core/texture_cache/texture_cache.cpp (+7 -1)
📝 src/video_core/texture_cache/texture_cache.h (+5 -0)

📄 Description

MoltenVK does not support the nullDescriptor feature of VK_EXT_robustness2. Instead, bind to the null image view or buffer as a workaround.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1001 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 9/20/2024 **Status:** ✅ Merged **Merged:** 9/21/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `null-descriptor` --- ### 📝 Commits (2) - [`c003b1a`](https://github.com/shadps4-emu/shadPS4/commit/c003b1a0a4c9c1bf3095594dbf8c57c1c112c2b0) vulkan: Add alternatives when nullDescriptor is not supported. - [`3efddd7`](https://github.com/shadps4-emu/shadPS4/commit/3efddd712de5a634c9d162a48eec75aba2d5e5fe) vulkan: Set identifying name on null image/image view/buffer ### 📊 Changes **8 files changed** (+46 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/buffer_cache/buffer_cache.cpp` (+5 -1) 📝 `src/video_core/buffer_cache/buffer_cache.h` (+5 -0) 📝 `src/video_core/renderer_vulkan/vk_compute_pipeline.cpp` (+5 -1) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp` (+9 -2) 📝 `src/video_core/renderer_vulkan/vk_instance.cpp` (+4 -1) 📝 `src/video_core/renderer_vulkan/vk_instance.h` (+6 -0) 📝 `src/video_core/texture_cache/texture_cache.cpp` (+7 -1) 📝 `src/video_core/texture_cache/texture_cache.h` (+5 -0) </details> ### 📄 Description MoltenVK does not support the `nullDescriptor` feature of `VK_EXT_robustness2`. Instead, bind to the null image view or buffer as a workaround. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>