[PR #995] [MERGED] vulkan: Enable VULKAN_HPP_NO_EXCEPTIONS broadly. #1870

New issue

Closed

opened 2026-02-27 21:14:16 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:14:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/995
Author: @squidbus
Created: 9/20/2024
Status: ✅ Merged
Merged: 9/25/2024
Merged by: @georgemoralis

Base: main ← Head: vk-no-exceptions

📝 Commits (2)

50f217a vulkan: Enable VULKAN_HPP_NO_EXCEPTIONS broadly.
6cb1222 vulkan: Use structured bindings for result where possible.

📊 Changes

22 files changed (+205 additions, -106 deletions)

View changed files

📝 src/imgui/renderer/imgui_core.cpp (+5 -1)
📝 src/imgui/renderer/imgui_impl_vulkan.h (+0 -1)
📝 src/video_core/buffer_cache/buffer.cpp (+3 -1)
📝 src/video_core/renderer_vulkan/renderer_vulkan.cpp (+9 -2)
📝 src/video_core/renderer_vulkan/vk_common.h (+3 -0)
📝 src/video_core/renderer_vulkan/vk_compute_pipeline.cpp (+14 -8)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp (+14 -8)
📝 src/video_core/renderer_vulkan/vk_instance.cpp (+48 -28)
📝 src/video_core/renderer_vulkan/vk_master_semaphore.cpp (+11 -2)
📝 src/video_core/renderer_vulkan/vk_pipeline_cache.cpp (+4 -1)
📝 src/video_core/renderer_vulkan/vk_platform.cpp (+18 -10)
📝 src/video_core/renderer_vulkan/vk_platform.h (+5 -1)
📝 src/video_core/renderer_vulkan/vk_rasterizer.cpp (+0 -1)
📝 src/video_core/renderer_vulkan/vk_rasterizer.h (+0 -1)
📝 src/video_core/renderer_vulkan/vk_resource_pool.cpp (+8 -2)
📝 src/video_core/renderer_vulkan/vk_scheduler.cpp (+9 -8)
📝 src/video_core/renderer_vulkan/vk_shader_util.cpp (+4 -7)
📝 src/video_core/renderer_vulkan/vk_swapchain.cpp (+35 -19)
📝 src/video_core/texture_cache/image.cpp (+0 -1)
📝 src/video_core/texture_cache/image_view.cpp (+4 -1)

...and 2 more files

📄 Description

This is a follow-up to some discussion in https://github.com/shadps4-emu/shadPS4/pull/906. Enables VULKAN_HPP_NO_EXCEPTIONS broadly, adjusting the necessary API calls to check the result value.

In some places a non-success result will fail gracefully, where it makes sense to or other checks on the output already do so. Others I have added asserts to basically mirror the current behavior but without exceptions; these can be adjusted in the future as needed. Feel free to comment if you have any specific preferences anywhere.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/995 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 9/20/2024 **Status:** ✅ Merged **Merged:** 9/25/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `vk-no-exceptions` --- ### 📝 Commits (2) - [`50f217a`](https://github.com/shadps4-emu/shadPS4/commit/50f217a0766f0b65f41c4c270919c839982d3730) vulkan: Enable VULKAN_HPP_NO_EXCEPTIONS broadly. - [`6cb1222`](https://github.com/shadps4-emu/shadPS4/commit/6cb1222b9a797efba122eaa050178e4a6228edec) vulkan: Use structured bindings for result where possible. ### 📊 Changes **22 files changed** (+205 additions, -106 deletions) <details> <summary>View changed files</summary> 📝 `src/imgui/renderer/imgui_core.cpp` (+5 -1) 📝 `src/imgui/renderer/imgui_impl_vulkan.h` (+0 -1) 📝 `src/video_core/buffer_cache/buffer.cpp` (+3 -1) 📝 `src/video_core/renderer_vulkan/renderer_vulkan.cpp` (+9 -2) 📝 `src/video_core/renderer_vulkan/vk_common.h` (+3 -0) 📝 `src/video_core/renderer_vulkan/vk_compute_pipeline.cpp` (+14 -8) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp` (+14 -8) 📝 `src/video_core/renderer_vulkan/vk_instance.cpp` (+48 -28) 📝 `src/video_core/renderer_vulkan/vk_master_semaphore.cpp` (+11 -2) 📝 `src/video_core/renderer_vulkan/vk_pipeline_cache.cpp` (+4 -1) 📝 `src/video_core/renderer_vulkan/vk_platform.cpp` (+18 -10) 📝 `src/video_core/renderer_vulkan/vk_platform.h` (+5 -1) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.cpp` (+0 -1) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.h` (+0 -1) 📝 `src/video_core/renderer_vulkan/vk_resource_pool.cpp` (+8 -2) 📝 `src/video_core/renderer_vulkan/vk_scheduler.cpp` (+9 -8) 📝 `src/video_core/renderer_vulkan/vk_shader_util.cpp` (+4 -7) 📝 `src/video_core/renderer_vulkan/vk_swapchain.cpp` (+35 -19) 📝 `src/video_core/texture_cache/image.cpp` (+0 -1) 📝 `src/video_core/texture_cache/image_view.cpp` (+4 -1) _...and 2 more files_ </details> ### 📄 Description This is a follow-up to some discussion in https://github.com/shadps4-emu/shadPS4/pull/906. Enables `VULKAN_HPP_NO_EXCEPTIONS` broadly, adjusting the necessary API calls to check the result value. In some places a non-success result will fail gracefully, where it makes sense to or other checks on the output already do so. Others I have added asserts to basically mirror the current behavior but without exceptions; these can be adjusted in the future as needed. Feel free to comment if you have any specific preferences anywhere. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>