mirror of
https://github.com/shadps4-emu/shadPS4.git
synced 2026-04-26 08:15:59 +03:00
[PR #992] [MERGED] Improve sceSystemServiceReceiveEvent stub #1868
Labels
No labels
Bloodborne
bug
contributor wanted
documentation
enhancement
frontend
good first issue
help wanted
linux
pull-request
question
release
verification progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shadPS4#1868
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/shadps4-emu/shadPS4/pull/992
Author: @StevenMiller123
Created: 9/20/2024
Status: ✅ Merged
Merged: 10/15/2024
Merged by: @polybiusproxy
Base:
main← Head:sceSystemServiceReceiveEvent📝 Commits (7)
121681cImprove sceSystemServiceReceiveEvent stubda7a4acclang6f41526Merge branch 'shadps4-emu:main' into sceSystemServiceReceiveEvent9ae626cMerge branch 'shadps4-emu:main' into sceSystemServiceReceiveEvent675a3fbMerge branch 'shadps4-emu:main' into sceSystemServiceReceiveEventf02b575Merge branch 'shadps4-emu:main' into sceSystemServiceReceiveEventa29971dMerge branch 'shadps4-emu:main' into sceSystemServiceReceiveEvent📊 Changes
3 files changed (+69 additions, -4 deletions)
View changed files
📝
src/core/libraries/error_codes.h(+1 -0)📝
src/core/libraries/system/systemservice.cpp(+6 -3)📝
src/core/libraries/system/systemservice.h(+62 -1)📄 Description
I've added both an EventType enum, and what should be the proper event struct, both based primarily off fpPS4 implementations. In the one game I've seen calling this function, the game runs a while loop until ReceiveEvent returns something other than 0, causing an infinite loop with the current implementation.
This needs testing with other games that can call this function, as I would assume some games may regress from the error return. If any regressions are found, please provide a log.
Confirmed improvements:
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.