[PR #906] [MERGED] vulkan: Disable exceptions for getImageFormatProperties and account for errors. #1824

Closed
opened 2026-02-27 21:14:06 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/906
Author: @squidbus
Created: 9/14/2024
Status: Merged
Merged: 9/14/2024
Merged by: @raphaelthegreat

Base: mainHead: format-prop-errors


📝 Commits (1)

  • a7d5dd6 vulkan: Disable exceptions for getImageFormatProperties and account for errors.

📊 Changes

1 file changed (+5 additions, -1 deletions)

View changed files

📝 src/video_core/texture_cache/image.cpp (+5 -1)

📄 Description

Potential fix for https://github.com/shadps4-emu/shadPS4/issues/894. Check for possible errors from getImageFormatProperties and fall back to single sampling.

Needs to be verified as I don't have a reproducible system/game. If it does not fix please provide more details on the crash for investigation.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/906 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 9/14/2024 **Status:** ✅ Merged **Merged:** 9/14/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `format-prop-errors` --- ### 📝 Commits (1) - [`a7d5dd6`](https://github.com/shadps4-emu/shadPS4/commit/a7d5dd6d303099fd35b456934138ba3253436cc1) vulkan: Disable exceptions for getImageFormatProperties and account for errors. ### 📊 Changes **1 file changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/texture_cache/image.cpp` (+5 -1) </details> ### 📄 Description Potential fix for https://github.com/shadps4-emu/shadPS4/issues/894. Check for possible errors from `getImageFormatProperties` and fall back to single sampling. Needs to be verified as I don't have a reproducible system/game. If it does not fix please provide more details on the crash for investigation. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 21:14:06 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#1824
No description provided.