[PR #899] [MERGED] Adding missing (IMAGE_SAMPLE) opcode #1820

New issue

Closed

opened 2026-02-27 21:14:05 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:14:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/899
Author: @Emulator-Team-2
Created: 9/13/2024
Status: ✅ Merged
Merged: 9/13/2024
Merged by: @polybiusproxy

Base: main ← Head: Fix-3

📝 Commits (1)

e7390cc added IMAGE_SAMPLE_L_O

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 src/shader_recompiler/frontend/translate/vector_memory.cpp (+1 -0)

📄 Description

Adding missing opcode used by Sengoku Basara: Sanada Yukimura-Den.

[Render.Recompiler] <Error> translate.cpp:LogMissingOpcode:452: Unknown opcode IMAGE_SAMPLE_L_O (1454, category = VectorMemory)
[Debug] <Critical> structured_control_flow.cpp:operator():835: Assertion Failed!
Shader translation has failed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/899 **Author:** [@Emulator-Team-2](https://github.com/Emulator-Team-2) **Created:** 9/13/2024 **Status:** ✅ Merged **Merged:** 9/13/2024 **Merged by:** [@polybiusproxy](https://github.com/polybiusproxy) **Base:** `main` ← **Head:** `Fix-3` --- ### 📝 Commits (1) - [`e7390cc`](https://github.com/shadps4-emu/shadPS4/commit/e7390ccabc1bf8702e55af4551e572c5ddc09a69) added IMAGE_SAMPLE_L_O ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/frontend/translate/vector_memory.cpp` (+1 -0) </details> ### 📄 Description Adding missing opcode used by Sengoku Basara: Sanada Yukimura-Den. ``` [Render.Recompiler] <Error> translate.cpp:LogMissingOpcode:452: Unknown opcode IMAGE_SAMPLE_L_O (1454, category = VectorMemory) [Debug] <Critical> structured_control_flow.cpp:operator():835: Assertion Failed! Shader translation has failed ``` ![1](https://github.com/user-attachments/assets/ba359da8-c6ae-4f87-8745-625f3baa46c7) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>