[PR #898] [CLOSED] Deleted #1818

New issue

Closed

opened 2026-02-27 21:14:05 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:14:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/898
Author: @siieo
Created: 9/13/2024
Status: ❌ Closed

Base: main ← Head: patch-1

📝 Commits (2)

41f73e8 Refactor SDL Audio Handling: Improve Formatting, Error Handling, and Volume Logic
193eaaa Update windows-qt.yml

📊 Changes

2 files changed (+58 additions, -80 deletions)

View changed files

📝 .github/workflows/windows-qt.yml (+1 -0)
📝 src/audio_core/sdl_audio.cpp (+57 -80)

📄 Description

…Volume Logic

Standardized code formatting for improved readability and consistency.
Added error handling for SDL audio stream initialization to manage failures more effectively.
Optimized volume adjustment logic and updated the volume handling to ensure proper channel volume settings.
Cleaned up redundant code and clarified code structure to enhance maintainability and performance.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/898 **Author:** [@siieo](https://github.com/siieo) **Created:** 9/13/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (2) - [`41f73e8`](https://github.com/shadps4-emu/shadPS4/commit/41f73e83c7b43e5ff3fd478cd1fbe1fcbc3122bc) Refactor SDL Audio Handling: Improve Formatting, Error Handling, and Volume Logic - [`193eaaa`](https://github.com/shadps4-emu/shadPS4/commit/193eaaada859e50da5e2ba76c40eeaefb896def7) Update windows-qt.yml ### 📊 Changes **2 files changed** (+58 additions, -80 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/windows-qt.yml` (+1 -0) 📝 `src/audio_core/sdl_audio.cpp` (+57 -80) </details> ### 📄 Description …Volume Logic - Standardized code formatting for improved readability and consistency. - Added error handling for SDL audio stream initialization to manage failures more effectively. - Optimized volume adjustment logic and updated the volume handling to ensure proper channel volume settings. - Cleaned up redundant code and clarified code structure to enhance maintainability and performance. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>