[PR #874] [MERGED] implement more nptrophy functions #1814

New issue

Closed

opened 2026-02-27 21:14:03 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:14:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/874
Author: @CrazyBloo
Created: 9/12/2024
Status: ✅ Merged
Merged: 9/12/2024
Merged by: @georgemoralis

Base: main ← Head: npTrophyFixes

📝 Commits (7)

1ca7bf8 fix review's from last pr
b88d173 save timestamp when trophies are unlocked
30930c7 implement GetTrophyInfo()
a685308 use strncpy instead of strcpy_s, should fix actions
66a4112 nptrophy: GetGameInfo(), GetGroupInfo()
447d687 various fixes
fdcd657 format

📊 Changes

2 files changed (+340 additions, -5 deletions)

View changed files

📝 src/core/libraries/np_trophy/np_trophy.cpp (+339 -4)
📝 src/core/libraries/np_trophy/trophy_ui.cpp (+1 -1)

📄 Description

this fixes games that would hang when trying to acquire trophy data

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/874 **Author:** [@CrazyBloo](https://github.com/CrazyBloo) **Created:** 9/12/2024 **Status:** ✅ Merged **Merged:** 9/12/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `npTrophyFixes` --- ### 📝 Commits (7) - [`1ca7bf8`](https://github.com/shadps4-emu/shadPS4/commit/1ca7bf83319fe4f603b6efec425cca51326b3d51) fix review's from last pr - [`b88d173`](https://github.com/shadps4-emu/shadPS4/commit/b88d1735b8473f8a045194c68fdcd8a87c0f5043) save timestamp when trophies are unlocked - [`30930c7`](https://github.com/shadps4-emu/shadPS4/commit/30930c7c821ecb01499995a2c4937ddfe98dcab5) implement GetTrophyInfo() - [`a685308`](https://github.com/shadps4-emu/shadPS4/commit/a6853080ad3c9f6f123884ec4bde62aae319bf53) use strncpy instead of strcpy_s, should fix actions - [`66a4112`](https://github.com/shadps4-emu/shadPS4/commit/66a411263e957b6b4fcd40ad75a486f0742331cf) nptrophy: GetGameInfo(), GetGroupInfo() - [`447d687`](https://github.com/shadps4-emu/shadPS4/commit/447d687fbc94ef5eed4a2d2986ca4a21cc0d09df) various fixes - [`fdcd657`](https://github.com/shadps4-emu/shadPS4/commit/fdcd6573e759277a3d1d9c48837926f4d7c24793) format ### 📊 Changes **2 files changed** (+340 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/np_trophy/np_trophy.cpp` (+339 -4) 📝 `src/core/libraries/np_trophy/trophy_ui.cpp` (+1 -1) </details> ### 📄 Description this fixes games that would hang when trying to acquire trophy data --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>