[PR #854] [MERGED] support for unlocking trophies #1808

New issue

Closed

opened 2026-02-27 21:14:02 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:14:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/854
Author: @CrazyBloo
Created: 9/9/2024
Status: ✅ Merged
Merged: 9/11/2024
Merged by: @georgemoralis

Base: main ← Head: npTrophy2

📝 Commits (10+)

f0ac597 add pugixml
a0d580e trophy_viewer: support for trophy unlocking
b8d7ea6 nptrophy: UnlockTrophy(), DestroyContext()
6dc8ef3 initial imgui popup
794770f queue to handle multiple trophies at once
315afc5 extract trophy info on game start + various fixes
dbd0404 platinum trophy support + extract trophy data on startup
625fa26 format
49253fa nptrophy: GetTrophyUnlockState
5990868 implement vinicius' reviews

📊 Changes

11 files changed (+607 additions, -53 deletions)

View changed files

📝 .gitmodules (+3 -0)
📝 CMakeLists.txt (+4 -1)
📝 externals/CMakeLists.txt (+5 -0)
➕ externals/pugixml (+1 -0)
📝 src/core/libraries/error_codes.h (+38 -2)
📝 src/core/libraries/np_trophy/np_trophy.cpp (+268 -24)
📝 src/core/libraries/np_trophy/np_trophy.h (+141 -16)
➕ src/core/libraries/np_trophy/trophy_ui.cpp (+74 -0)
➕ src/core/libraries/np_trophy/trophy_ui.h (+40 -0)
📝 src/emulator.cpp (+11 -0)
📝 src/qt_gui/trophy_viewer.cpp (+22 -10)

📄 Description

edit: this is ready for review, when Vinicius finishes the image support for imgui i will make another pr with trophy icons

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/854 **Author:** [@CrazyBloo](https://github.com/CrazyBloo) **Created:** 9/9/2024 **Status:** ✅ Merged **Merged:** 9/11/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `npTrophy2` --- ### 📝 Commits (10+) - [`f0ac597`](https://github.com/shadps4-emu/shadPS4/commit/f0ac5977a5636a6acb6fb4b9bacf087046cb9582) add pugixml - [`a0d580e`](https://github.com/shadps4-emu/shadPS4/commit/a0d580e348294b694daf30213cc9cf3f2ddb23bd) trophy_viewer: support for trophy unlocking - [`b8d7ea6`](https://github.com/shadps4-emu/shadPS4/commit/b8d7ea66c44203174164d0acb94da3951b7bb1e0) nptrophy: UnlockTrophy(), DestroyContext() - [`6dc8ef3`](https://github.com/shadps4-emu/shadPS4/commit/6dc8ef3f702ed11c60c3dfdba2d794a4d1f4a92a) initial imgui popup - [`794770f`](https://github.com/shadps4-emu/shadPS4/commit/794770f94e098647915f312c566f4a81ff955fb0) queue to handle multiple trophies at once - [`315afc5`](https://github.com/shadps4-emu/shadPS4/commit/315afc52fab664fd21fa14c9e5794fa73c6f4d65) extract trophy info on game start + various fixes - [`dbd0404`](https://github.com/shadps4-emu/shadPS4/commit/dbd0404ed5e7729462131839eb702dd7760710f0) platinum trophy support + extract trophy data on startup - [`625fa26`](https://github.com/shadps4-emu/shadPS4/commit/625fa2651de50a577691de511523fbf50302ef59) format - [`49253fa`](https://github.com/shadps4-emu/shadPS4/commit/49253fa92afdadaa7dee1b859a8dbfa3b0f49735) nptrophy: GetTrophyUnlockState - [`5990868`](https://github.com/shadps4-emu/shadPS4/commit/599086835527400d6dbf5636d5f3b5da86ef02a3) implement vinicius' reviews ### 📊 Changes **11 files changed** (+607 additions, -53 deletions) <details> <summary>View changed files</summary> 📝 `.gitmodules` (+3 -0) 📝 `CMakeLists.txt` (+4 -1) 📝 `externals/CMakeLists.txt` (+5 -0) ➕ `externals/pugixml` (+1 -0) 📝 `src/core/libraries/error_codes.h` (+38 -2) 📝 `src/core/libraries/np_trophy/np_trophy.cpp` (+268 -24) 📝 `src/core/libraries/np_trophy/np_trophy.h` (+141 -16) ➕ `src/core/libraries/np_trophy/trophy_ui.cpp` (+74 -0) ➕ `src/core/libraries/np_trophy/trophy_ui.h` (+40 -0) 📝 `src/emulator.cpp` (+11 -0) 📝 `src/qt_gui/trophy_viewer.cpp` (+22 -10) </details> ### 📄 Description edit: this is ready for review, when Vinicius finishes the image support for imgui i will make another pr with trophy icons --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>