[PR #828] [MERGED] vulkan: Limit multisampling to supported sample counts. #1792

New issue

Closed

opened 2026-02-27 21:13:58 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:13:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/828
Author: @squidbus
Created: 9/7/2024
Status: ✅ Merged
Merged: 9/12/2024
Merged by: @raphaelthegreat

Base: main ← Head: vk-sample-count

📝 Commits (1)

cb56283 vulkan: Limit multisampling to supported sample counts.

📊 Changes

5 files changed (+29 additions, -6 deletions)

View changed files

📝 src/video_core/renderer_vulkan/liverpool_to_vk.cpp (+11 -1)
📝 src/video_core/renderer_vulkan/liverpool_to_vk.h (+1 -1)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp (+2 -1)
📝 src/video_core/renderer_vulkan/vk_instance.h (+7 -0)
📝 src/video_core/texture_cache/image.cpp (+8 -3)

📄 Description

Limits requested multi-sampling for framebuffers and images to the maximum supported.

For images, this is the sampleCount bitmask from VkImageFormatProperties.
For framebuffers, this is the intersection of the supported framebuffer color, depth, and stencil sample counts from VkPhysicalDeviceLimits.

When a sample count is unsupported, it divides by 2 and tries again, with a minimum of 1 sample.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/828 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 9/7/2024 **Status:** ✅ Merged **Merged:** 9/12/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `vk-sample-count` --- ### 📝 Commits (1) - [`cb56283`](https://github.com/shadps4-emu/shadPS4/commit/cb56283da0a49872d16549ae33deab2116fe90a7) vulkan: Limit multisampling to supported sample counts. ### 📊 Changes **5 files changed** (+29 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/liverpool_to_vk.cpp` (+11 -1) 📝 `src/video_core/renderer_vulkan/liverpool_to_vk.h` (+1 -1) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp` (+2 -1) 📝 `src/video_core/renderer_vulkan/vk_instance.h` (+7 -0) 📝 `src/video_core/texture_cache/image.cpp` (+8 -3) </details> ### 📄 Description Limits requested multi-sampling for framebuffers and images to the maximum supported. * For images, this is the `sampleCount` bitmask from `VkImageFormatProperties`. * For framebuffers, this is the intersection of the supported framebuffer color, depth, and stencil sample counts from `VkPhysicalDeviceLimits`. When a sample count is unsupported, it divides by 2 and tries again, with a minimum of 1 sample. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>