[PR #809] [MERGED] Standardize game_data directory for game metadata. #1784

New issue

Closed

opened 2026-02-27 21:13:56 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:13:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/809
Author: @squidbus
Created: 9/6/2024
Status: ✅ Merged
Merged: 9/6/2024
Merged by: @georgemoralis

Base: main ← Head: fix-paths

📝 Commits (1)

04d79e5 Standardize game_data directory for game metadata.

📊 Changes

7 files changed (+17 additions, -12 deletions)

View changed files

📝 src/common/path_util.cpp (+1 -0)
📝 src/common/path_util.h (+2 -0)
📝 src/core/file_format/trp.cpp (+4 -2)
📝 src/qt_gui/game_grid_frame.cpp (+4 -3)
📝 src/qt_gui/game_list_frame.cpp (+4 -4)
📝 src/qt_gui/main.cpp (+0 -1)
📝 src/qt_gui/trophy_viewer.cpp (+2 -2)

📄 Description

Various references to the game_data folder are currently hardcoded throughout the GUI code for trophies and background images. As a result if that does not match the determined user directory in path_util, files will be placed in the wrong place.

This PR makes sure they are all going through GetUserDir so they have the right base directory, introducing a new path type for game metadata files like these.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/809 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 9/6/2024 **Status:** ✅ Merged **Merged:** 9/6/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `fix-paths` --- ### 📝 Commits (1) - [`04d79e5`](https://github.com/shadps4-emu/shadPS4/commit/04d79e5d7d9372847f3e7e0e2d849e9b5fd7916f) Standardize game_data directory for game metadata. ### 📊 Changes **7 files changed** (+17 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/common/path_util.cpp` (+1 -0) 📝 `src/common/path_util.h` (+2 -0) 📝 `src/core/file_format/trp.cpp` (+4 -2) 📝 `src/qt_gui/game_grid_frame.cpp` (+4 -3) 📝 `src/qt_gui/game_list_frame.cpp` (+4 -4) 📝 `src/qt_gui/main.cpp` (+0 -1) 📝 `src/qt_gui/trophy_viewer.cpp` (+2 -2) </details> ### 📄 Description Various references to the `game_data` folder are currently hardcoded throughout the GUI code for trophies and background images. As a result if that does not match the determined user directory in `path_util`, files will be placed in the wrong place. This PR makes sure they are all going through `GetUserDir` so they have the right base directory, introducing a new path type for game metadata files like these. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>