[PR #768] [MERGED] misc: Fix a few compiler warnings. #1761

Closed
opened 2026-02-27 21:13:50 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/768
Author: @squidbus
Created: 9/4/2024
Status: Merged
Merged: 9/4/2024
Merged by: @georgemoralis

Base: mainHead: warning-fix


📝 Commits (1)

  • 9eadec8 misc: Fix a few compiler warnings.

📊 Changes

2 files changed (+5 additions, -0 deletions)

View changed files

📝 src/core/libraries/network/net.h (+4 -0)
📝 src/video_core/renderer_vulkan/vk_common.h (+1 -0)

📄 Description

  • Fix warning for redefining HTONLL/NTOHLL by only defining if not already defined.
  • Fix warning in ImageViewInfo about explicitly defaulted three-way comparison being implicitly deleted due to inability to three-way compare Vulkan data types, by enabling VULKAN_HPP_HAS_SPACESHIP_OPERATOR.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/768 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 9/4/2024 **Status:** ✅ Merged **Merged:** 9/4/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `warning-fix` --- ### 📝 Commits (1) - [`9eadec8`](https://github.com/shadps4-emu/shadPS4/commit/9eadec849cc99af90242bdd42a2596432e6f4b7e) misc: Fix a few compiler warnings. ### 📊 Changes **2 files changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/network/net.h` (+4 -0) 📝 `src/video_core/renderer_vulkan/vk_common.h` (+1 -0) </details> ### 📄 Description * Fix warning for redefining `HTONLL`/`NTOHLL` by only defining if not already defined. * Fix warning in `ImageViewInfo` about explicitly defaulted three-way comparison being implicitly deleted due to inability to three-way compare Vulkan data types, by enabling `VULKAN_HPP_HAS_SPACESHIP_OPERATOR`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 21:13:50 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#1761
No description provided.