[PR #767] [MERGED] Message Dialog library #1760

New issue

Closed

opened 2026-02-27 21:13:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:13:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/767
Author: @viniciuslrangel
Created: 9/4/2024
Status: ✅ Merged
Merged: 9/8/2024
Merged by: @georgemoralis

Base: main ← Head: lib-SaveData

📝 Commits (7)

2e4eac3 system/MsgDialog: types & basic text display
8c1a6fb system/MsgDialog: User message dialog
ad57ab8 system/MsgDialog: RAII for MsgDialog ui
6fdfde7 system/MsgDialog: Progress bar dialog
299711f system/MsgDialog: System message texts
f1218ad system/MsgDialog: copy all ui state to local memory
c481650 system/MsgDialog: debug logging

📊 Changes

9 files changed (+712 additions, -149 deletions)

View changed files

📝 CMakeLists.txt (+3 -0)
➕ src/common/fixed_value.h (+35 -0)
📝 src/core/libraries/system/commondialog.cpp (+14 -6)
📝 src/core/libraries/system/commondialog.h (+39 -4)
📝 src/core/libraries/system/msgdialog.cpp (+127 -49)
📝 src/core/libraries/system/msgdialog.h (+17 -90)
➕ src/core/libraries/system/msgdialog_ui.cpp (+273 -0)
➕ src/core/libraries/system/msgdialog_ui.h (+177 -0)
➕ src/imgui/imgui_std.h (+27 -0)

📄 Description

~~- based on the #598 branch, gonna rebase after merge~~

Check discord homebrew-downloads channel for a test binary

Gamepad as first-class

Msg dialog

State
Basic text
Buttons
Progress bar
System error

~~### Save Dialog~~ I'll split it to another PR

Demo

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/767 **Author:** [@viniciuslrangel](https://github.com/viniciuslrangel) **Created:** 9/4/2024 **Status:** ✅ Merged **Merged:** 9/8/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `lib-SaveData` --- ### 📝 Commits (7) - [`2e4eac3`](https://github.com/shadps4-emu/shadPS4/commit/2e4eac3d1910b64ffa5e2097e707a233fbafba03) system/MsgDialog: types & basic text display - [`8c1a6fb`](https://github.com/shadps4-emu/shadPS4/commit/8c1a6fbb5e2c0326b71691e3b14f7a62c198bf79) system/MsgDialog: User message dialog - [`ad57ab8`](https://github.com/shadps4-emu/shadPS4/commit/ad57ab8fee35fc15837ec082277a3fd5b7fcd2ae) system/MsgDialog: RAII for MsgDialog ui - [`6fdfde7`](https://github.com/shadps4-emu/shadPS4/commit/6fdfde764968357422d6532424d73531429995f0) system/MsgDialog: Progress bar dialog - [`299711f`](https://github.com/shadps4-emu/shadPS4/commit/299711fc9e5398e2330e584a547a61158ce5becb) system/MsgDialog: System message texts - [`f1218ad`](https://github.com/shadps4-emu/shadPS4/commit/f1218ad9f5ad5badad89021b31807227d7d40ee4) system/MsgDialog: copy all ui state to local memory - [`c481650`](https://github.com/shadps4-emu/shadPS4/commit/c48165070555bfada869b36f24dc83fb5d9e9590) system/MsgDialog: debug logging ### 📊 Changes **9 files changed** (+712 additions, -149 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+3 -0) ➕ `src/common/fixed_value.h` (+35 -0) 📝 `src/core/libraries/system/commondialog.cpp` (+14 -6) 📝 `src/core/libraries/system/commondialog.h` (+39 -4) 📝 `src/core/libraries/system/msgdialog.cpp` (+127 -49) 📝 `src/core/libraries/system/msgdialog.h` (+17 -90) ➕ `src/core/libraries/system/msgdialog_ui.cpp` (+273 -0) ➕ `src/core/libraries/system/msgdialog_ui.h` (+177 -0) ➕ `src/imgui/imgui_std.h` (+27 -0) </details> ### 📄 Description ~- based on the #598 branch, gonna rebase after merge~ > Check discord homebrew-downloads channel for a test binary Gamepad as first-class ### Msg dialog - [x] State - [x] Basic text - [x] Buttons - [x] Progress bar - [x] System error ~### Save Dialog~ I'll split it to another PR ## Demo ![image](https://github.com/user-attachments/assets/50f14cdf-1c85-4da9-9f90-a63eb5238d14) ![image](https://github.com/user-attachments/assets/b0a7ac07-b11b-4778-8229-197ef70d2cca) ![image](https://github.com/user-attachments/assets/71c3f54a-b434-4ddf-b238-cafc22ddf036) ![image](https://github.com/user-attachments/assets/c282f230-f4ca-463a-8088-629d4532c9e4) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>