[PR #749] [MERGED] Fix warnings #1747

New issue

Closed

opened 2026-02-27 21:13:48 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:13:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/749
Author: @oltolm
Created: 9/3/2024
Status: ✅ Merged
Merged: 9/3/2024
Merged by: @raphaelthegreat

Base: main ← Head: fix_warnings

📝 Commits (2)

34f6e05 suppress warning in vk_mem_alloc.h
df3da50 fix warnings in cheats_patches.cpp

📊 Changes

7 files changed (+33 additions, -14 deletions)

View changed files

📝 src/qt_gui/cheats_patches.cpp (+15 -14)
📝 src/video_core/buffer_cache/buffer.cpp (+3 -0)
📝 src/video_core/renderer_vulkan/renderer_vulkan.cpp (+3 -0)
📝 src/video_core/renderer_vulkan/vk_common.cpp (+3 -0)
📝 src/video_core/renderer_vulkan/vk_instance.cpp (+3 -0)
📝 src/video_core/texture_cache/image.cpp (+3 -0)
📝 src/video_core/texture_cache/tile_manager.cpp (+3 -0)

📄 Description

fixes warnings like this

C:/src/shadPS4/externals/vma/include/vk_mem_alloc.h:16141:22: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
 16141 |     VmaAllocationInfo* pAllocationInfo)
       |                      ^
C:/src/shadPS4/externals/vma/include/vk_mem_alloc.h:16141:22: note: insert '_Nullable' if the pointer may be null
 16141 |     VmaAllocationInfo* pAllocationInfo)
       |                      ^
       |                        _Nullable
C:/src/shadPS4/externals/vma/include/vk_mem_alloc.h:16141:22: note: insert '_Nonnull' if the pointer should never be null
 16141 |     VmaAllocationInfo* pAllocationInfo)
       |                      ^
       |                        _Nonnull

C:/src/shadPS4/src/qt_gui/cheats_patches.cpp:1096:49: warning: implicit capture of 'this' with a capture default of '=' is deprecated [-Wdeprecated-this-capture]
 1096 |                             [=](bool checked) { applyPatch(patchName, checked); });
      |                                                 ^
C:/src/shadPS4/src/qt_gui/cheats_patches.cpp:1096:30: note: add an explicit capture of 'this' to capture '*this' by reference
 1096 |                             [=](bool checked) { applyPatch(patchName, checked); });
      |                              ^
      |                               , this

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/749 **Author:** [@oltolm](https://github.com/oltolm) **Created:** 9/3/2024 **Status:** ✅ Merged **Merged:** 9/3/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `fix_warnings` --- ### 📝 Commits (2) - [`34f6e05`](https://github.com/shadps4-emu/shadPS4/commit/34f6e05d49640d58ed93bfebf0f71343d20017d3) suppress warning in vk_mem_alloc.h - [`df3da50`](https://github.com/shadps4-emu/shadPS4/commit/df3da50ea6da1b33a53d1c94d6fce956088f7dd1) fix warnings in cheats_patches.cpp ### 📊 Changes **7 files changed** (+33 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `src/qt_gui/cheats_patches.cpp` (+15 -14) 📝 `src/video_core/buffer_cache/buffer.cpp` (+3 -0) 📝 `src/video_core/renderer_vulkan/renderer_vulkan.cpp` (+3 -0) 📝 `src/video_core/renderer_vulkan/vk_common.cpp` (+3 -0) 📝 `src/video_core/renderer_vulkan/vk_instance.cpp` (+3 -0) 📝 `src/video_core/texture_cache/image.cpp` (+3 -0) 📝 `src/video_core/texture_cache/tile_manager.cpp` (+3 -0) </details> ### 📄 Description fixes warnings like this ``` C:/src/shadPS4/externals/vma/include/vk_mem_alloc.h:16141:22: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness] 16141 | VmaAllocationInfo* pAllocationInfo) | ^ C:/src/shadPS4/externals/vma/include/vk_mem_alloc.h:16141:22: note: insert '_Nullable' if the pointer may be null 16141 | VmaAllocationInfo* pAllocationInfo) | ^ | _Nullable C:/src/shadPS4/externals/vma/include/vk_mem_alloc.h:16141:22: note: insert '_Nonnull' if the pointer should never be null 16141 | VmaAllocationInfo* pAllocationInfo) | ^ | _Nonnull ``` ``` C:/src/shadPS4/src/qt_gui/cheats_patches.cpp:1096:49: warning: implicit capture of 'this' with a capture default of '=' is deprecated [-Wdeprecated-this-capture] 1096 | [=](bool checked) { applyPatch(patchName, checked); }); | ^ C:/src/shadPS4/src/qt_gui/cheats_patches.cpp:1096:30: note: add an explicit capture of 'this' to capture '*this' by reference 1096 | [=](bool checked) { applyPatch(patchName, checked); }); | ^ | , this ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>