[PR #736] [MERGED] Additional VirtualQuery improvements #1741

New issue

Closed

opened 2026-02-27 21:13:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:13:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/736
Author: @StevenMiller123
Created: 9/2/2024
Status: ✅ Merged
Merged: 9/3/2024
Merged by: @georgemoralis

Base: main ← Head: MoreVirtualQuery

📝 Commits (6)

8162889 Assign is_stack and is_pooled
f8d71b5 Fix MemoryManager::VirtualQuery header
0503054 Grammar
dc1313e Always assign memory_type and offset
9a772aa Clang fix
04fbd7b Clang

📊 Changes

3 files changed (+10 additions, -5 deletions)

View changed files

📝 src/core/libraries/kernel/memory_management.h (+1 -1)
📝 src/core/memory.cpp (+6 -2)
📝 src/core/memory.h (+3 -2)

📄 Description

At the suggestion of @georgemoralis, I've adjusted sceKernelVirtualQuery to properly initialize all variables in the OrbisVirtualQueryInfo struct. I also resolved some minor nits I had with the code.

In my testing, this doesn't appear to improve or regress any games using VirtualQuery.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/736 **Author:** [@StevenMiller123](https://github.com/StevenMiller123) **Created:** 9/2/2024 **Status:** ✅ Merged **Merged:** 9/3/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `MoreVirtualQuery` --- ### 📝 Commits (6) - [`8162889`](https://github.com/shadps4-emu/shadPS4/commit/816288962b8622f54fd9d97375a2a9057b6f8da4) Assign is_stack and is_pooled - [`f8d71b5`](https://github.com/shadps4-emu/shadPS4/commit/f8d71b59d9009b79f153516889959a1ff9b1595e) Fix MemoryManager::VirtualQuery header - [`0503054`](https://github.com/shadps4-emu/shadPS4/commit/0503054b409774a55ec10731eb8efce3c023bc99) Grammar - [`dc1313e`](https://github.com/shadps4-emu/shadPS4/commit/dc1313ea3cde87a069ba95ad89acbb20b5c4617c) Always assign memory_type and offset - [`9a772aa`](https://github.com/shadps4-emu/shadPS4/commit/9a772aa2f50e98b9650b805829b001644ea62496) Clang fix - [`04fbd7b`](https://github.com/shadps4-emu/shadPS4/commit/04fbd7b9e775d67b9b59ed4bd0bc54ec03847cbf) Clang ### 📊 Changes **3 files changed** (+10 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/kernel/memory_management.h` (+1 -1) 📝 `src/core/memory.cpp` (+6 -2) 📝 `src/core/memory.h` (+3 -2) </details> ### 📄 Description At the suggestion of @georgemoralis, I've adjusted sceKernelVirtualQuery to properly initialize all variables in the OrbisVirtualQueryInfo struct. I also resolved some minor nits I had with the code. In my testing, this doesn't appear to improve or regress any games using VirtualQuery. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>