[PR #704] [MERGED] [bb-hacks] More shader skips, video player fix and ReleaseWithDebInfo fix #1728

New issue

Closed

opened 2026-02-27 21:13:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:13:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/704
Author: @rafael-57
Created: 9/1/2024
Status: ✅ Merged
Merged: 9/2/2024
Merged by: @raphaelthegreat

Base: bb-hacks ← Head: bb-hacks

📝 Commits (1)

82c3f51 More shader skips, video player fix and ReleaseWithDebInfo fix

📊 Changes

2 files changed (+8 additions, -5 deletions)

View changed files

📝 src/video_core/renderer_vulkan/vk_compute_pipeline.cpp (+4 -2)
📝 src/video_core/renderer_vulkan/vk_pipeline_cache.cpp (+4 -3)

📄 Description

Skips problematic shaders that cause hangs during warp/death
Example of one shader:

[Render.Vulkan] <Warning> translate.cpp:GetSrc:171: Input abs modifier on integer instruction
[Render.Vulkan] <Info> vk_shader_cache.cpp:CompileModule:119: Compiling vs shader 0xddfbac23
[Render.Vulkan] <Error> vk_platform.cpp:DebugUtilsCallback:59: VUID-VkShaderModuleCreateInfo-pCode-08737: Validation Error: [ VUID-VkShaderModuleCreateInfo-pCode-08737 ] | MessageID = 0xa5625282 | vkCreateShaderModule(): pCreateInfo->pCode (spirv-val produced an error):
Index is out of bounds: OpAccessChain cannot find index 4 into the structure <id> '32[%32]'. This structure has 4 members. Largest valid index is 3.
  %u32_id_4 = OpConstant %u32_id 4
. The Vulkan spec states: If pCode is a pointer to SPIR-V code, pCode must adhere to the validation rules described by the Validation Rules within a Module section of the SPIR-V Environment appendix (https://vulkan.lunarg.com/doc/view/1.3.290.0/windows/1.3-extensions/vkspec.html#VUID-VkShaderModuleCreateInfo-pCode-08737)
[Render.Vulkan] <Error> vk_platform.cpp:DebugUtilsCallback:59: VUID-VkDescriptorSetLayoutCreateInfo-flags-00281: Validation Error: [ VUID-VkDescriptorSetLayoutCreateInfo-flags-00281 ] | MessageID = 0x54023d1d | vkCreateDescriptorSetLayout(): pCreateInfo->flags contains VK_DESCRIPTOR_SET_LAYOUT_CREATE_PUSH_DESCRIPTOR_BIT_KHR, but the total descriptor count in layout (33) must not be greater than maxPushDescriptors (32). The Vulkan spec states: If flags contains VK_DESCRIPTOR_SET_LAYOUT_CREATE_PUSH_DESCRIPTOR_BIT_KHR, then the total number of elements of all bindings must be less than or equal to VkPhysicalDevicePushDescriptorPropertiesKHR::maxPushDescriptors (https://vulkan.lunarg.com/doc/view/1.3.290.0/windows/1.3-extensions/vkspec.html#VUID-VkDescriptorSetLayoutCreateInfo-flags-00281)

Avoid skipping a shader that causes video player to be black. - Adjo's
Fix for building with ReleaseWithDebInfo - Adjo's

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/704 **Author:** [@rafael-57](https://github.com/rafael-57) **Created:** 9/1/2024 **Status:** ✅ Merged **Merged:** 9/2/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `bb-hacks` ← **Head:** `bb-hacks` --- ### 📝 Commits (1) - [`82c3f51`](https://github.com/shadps4-emu/shadPS4/commit/82c3f51e21aa5043731483a7ba3cde6f21e348ca) More shader skips, video player fix and ReleaseWithDebInfo fix ### 📊 Changes **2 files changed** (+8 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/vk_compute_pipeline.cpp` (+4 -2) 📝 `src/video_core/renderer_vulkan/vk_pipeline_cache.cpp` (+4 -3) </details> ### 📄 Description Skips problematic shaders that cause hangs during warp/death Example of one shader: ``` [Render.Vulkan] <Warning> translate.cpp:GetSrc:171: Input abs modifier on integer instruction [Render.Vulkan] <Info> vk_shader_cache.cpp:CompileModule:119: Compiling vs shader 0xddfbac23 [Render.Vulkan] <Error> vk_platform.cpp:DebugUtilsCallback:59: VUID-VkShaderModuleCreateInfo-pCode-08737: Validation Error: [ VUID-VkShaderModuleCreateInfo-pCode-08737 ] | MessageID = 0xa5625282 | vkCreateShaderModule(): pCreateInfo->pCode (spirv-val produced an error): Index is out of bounds: OpAccessChain cannot find index 4 into the structure <id> '32[%32]'. This structure has 4 members. Largest valid index is 3. %u32_id_4 = OpConstant %u32_id 4 . The Vulkan spec states: If pCode is a pointer to SPIR-V code, pCode must adhere to the validation rules described by the Validation Rules within a Module section of the SPIR-V Environment appendix (https://vulkan.lunarg.com/doc/view/1.3.290.0/windows/1.3-extensions/vkspec.html#VUID-VkShaderModuleCreateInfo-pCode-08737) [Render.Vulkan] <Error> vk_platform.cpp:DebugUtilsCallback:59: VUID-VkDescriptorSetLayoutCreateInfo-flags-00281: Validation Error: [ VUID-VkDescriptorSetLayoutCreateInfo-flags-00281 ] | MessageID = 0x54023d1d | vkCreateDescriptorSetLayout(): pCreateInfo->flags contains VK_DESCRIPTOR_SET_LAYOUT_CREATE_PUSH_DESCRIPTOR_BIT_KHR, but the total descriptor count in layout (33) must not be greater than maxPushDescriptors (32). The Vulkan spec states: If flags contains VK_DESCRIPTOR_SET_LAYOUT_CREATE_PUSH_DESCRIPTOR_BIT_KHR, then the total number of elements of all bindings must be less than or equal to VkPhysicalDevicePushDescriptorPropertiesKHR::maxPushDescriptors (https://vulkan.lunarg.com/doc/view/1.3.290.0/windows/1.3-extensions/vkspec.html#VUID-VkDescriptorSetLayoutCreateInfo-flags-00281) ``` Avoid skipping a shader that causes video player to be black. - Adjo's Fix for building with ReleaseWithDebInfo - Adjo's --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>