[PR #696] [CLOSED] Fix segfault when unable to find PFSCOffset in pfs_image #1719

New issue

Closed

opened 2026-02-27 21:13:41 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:13:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/696
Author: @Mariuspersen
Created: 8/31/2024
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (5)

481e18a video_core: Some bloodborne hacks
ba89552 Fix segfault when unable to find PFSCOffset in pfs_image
d920a9e Update pkg.cpp
7b06002 Merge branch 'main' into bb-hacks
733fe47 bb-hacks

📊 Changes

5 files changed (+87 additions, -2 deletions)

View changed files

📝 .gitignore (+1 -0)
📝 src/core/file_format/pkg.cpp (+5 -0)
📝 src/core/libraries/kernel/thread_management.cpp (+9 -0)
📝 src/video_core/renderer_vulkan/vk_compute_pipeline.cpp (+69 -1)
📝 src/video_core/renderer_vulkan/vk_pipeline_cache.cpp (+3 -1)

📄 Description

Had a situation where the PKG I had was corrupted or for some reason the magic number could not be found.
There is no error checking if GetPFSCOffset returns -1 causing a segfault.

This pull request adds a error message if anyone else encounters this problem

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/696 **Author:** [@Mariuspersen](https://github.com/Mariuspersen) **Created:** 8/31/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (5) - [`481e18a`](https://github.com/shadps4-emu/shadPS4/commit/481e18a245f8a19a540877778d7bc45a91672519) video_core: Some bloodborne hacks - [`ba89552`](https://github.com/shadps4-emu/shadPS4/commit/ba89552373341be2edecb7e6cb8f8ebec1417e24) Fix segfault when unable to find PFSCOffset in pfs_image - [`d920a9e`](https://github.com/shadps4-emu/shadPS4/commit/d920a9e5449a2624e6a03efad02c9bb87d29ad9c) Update pkg.cpp - [`7b06002`](https://github.com/shadps4-emu/shadPS4/commit/7b06002eb45b4a7d864cc59bfd60b807532695f3) Merge branch 'main' into bb-hacks - [`733fe47`](https://github.com/shadps4-emu/shadPS4/commit/733fe478392601ea1ceaee2afd3166b66ea56918) bb-hacks ### 📊 Changes **5 files changed** (+87 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) 📝 `src/core/file_format/pkg.cpp` (+5 -0) 📝 `src/core/libraries/kernel/thread_management.cpp` (+9 -0) 📝 `src/video_core/renderer_vulkan/vk_compute_pipeline.cpp` (+69 -1) 📝 `src/video_core/renderer_vulkan/vk_pipeline_cache.cpp` (+3 -1) </details> ### 📄 Description Had a situation where the PKG I had was corrupted or for some reason the magic number could not be found. There is no error checking if GetPFSCOffset returns -1 causing a segfault. This pull request adds a error message if anyone else encounters this problem --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>