[PR #674] [MERGED] Allow graphics/compute shader list for skipping #1705

New issue

Closed

opened 2026-02-27 21:13:38 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:13:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/674
Author: @jnackmclain
Created: 8/30/2024
Status: ✅ Merged
Merged: 8/30/2024
Merged by: @raphaelthegreat

Base: main ← Head: skip-shader-list

📝 Commits (5)

72011e3 Allow graphics/compute shader list for skipping
e34eaee nintendo ultra 64 + formatting
9f2991e indentation..
6d7df8a allow empty array in ShouldSkipShader
f996e4f simpler check for skip hashes

📊 Changes

2 files changed (+27 additions, -6 deletions)

View changed files

📝 src/video_core/renderer_vulkan/vk_pipeline_cache.cpp (+25 -4)
📝 src/video_core/renderer_vulkan/vk_pipeline_cache.h (+2 -2)

📄 Description

This makes it easier for local builders to skip shaders for debugging and testing.
This is helpful for debugging troublesome shaders on forks/branches while merging upstream changes as it provides a specific place to put them to remain constant.

RefreshComputeKey and RefreshGraphicsKey now return bools to check for skips or not.
Logged a warning when skipped for clarity in the log when shaders are skipped and of type

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/674 **Author:** [@jnackmclain](https://github.com/jnackmclain) **Created:** 8/30/2024 **Status:** ✅ Merged **Merged:** 8/30/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `skip-shader-list` --- ### 📝 Commits (5) - [`72011e3`](https://github.com/shadps4-emu/shadPS4/commit/72011e374b20951c99ace0fe79502cb1d4bdeb6a) Allow graphics/compute shader list for skipping - [`e34eaee`](https://github.com/shadps4-emu/shadPS4/commit/e34eaee2e24339a19c1ec63036c30673127a08bc) nintendo ultra 64 + formatting - [`9f2991e`](https://github.com/shadps4-emu/shadPS4/commit/9f2991e49f05719a92363edbd36f94ceed5eed30) indentation.. - [`6d7df8a`](https://github.com/shadps4-emu/shadPS4/commit/6d7df8aad7634a50243c0f436011b0fcc129b6e7) allow empty array in ShouldSkipShader - [`f996e4f`](https://github.com/shadps4-emu/shadPS4/commit/f996e4f204d9b8beacc4b6d1cdd331201e969d98) simpler check for skip hashes ### 📊 Changes **2 files changed** (+27 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/vk_pipeline_cache.cpp` (+25 -4) 📝 `src/video_core/renderer_vulkan/vk_pipeline_cache.h` (+2 -2) </details> ### 📄 Description This makes it easier for local builders to skip shaders for debugging and testing. This is helpful for debugging troublesome shaders on forks/branches while merging upstream changes as it provides a specific place to put them to remain constant. RefreshComputeKey and RefreshGraphicsKey now return bools to check for skips or not. Logged a warning when skipped for clarity in the log when shaders are skipped and of type ![image](https://github.com/user-attachments/assets/d69edda2-b354-40cd-afbf-23692ea8a6cb) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>