[PR #610] [MERGED] AvPlayer: Handle Initialization errors #1664

New issue

Closed

opened 2026-02-27 21:13:28 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:13:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/610
Author: @roamic
Created: 8/27/2024
Status: ✅ Merged
Merged: 8/27/2024
Merged by: @georgemoralis

Base: main ← Head: avplayer-handle-init-errors

📝 Commits (1)

2d354a0 AvPlayer: Handle Initialization errors

📊 Changes

8 files changed (+90 additions, -61 deletions)

View changed files

📝 src/core/libraries/avplayer/avplayer_data_streamer.h (+3 -0)
📝 src/core/libraries/avplayer/avplayer_file_streamer.cpp (+17 -13)
📝 src/core/libraries/avplayer/avplayer_file_streamer.h (+3 -1)
📝 src/core/libraries/avplayer/avplayer_impl.cpp (+6 -3)
📝 src/core/libraries/avplayer/avplayer_source.cpp (+31 -23)
📝 src/core/libraries/avplayer/avplayer_source.h (+4 -4)
📝 src/core/libraries/avplayer/avplayer_state.cpp (+23 -14)
📝 src/core/libraries/avplayer/avplayer_state.h (+3 -3)

📄 Description

Replaced asserts during the initialization stage with error propagation. This fixes some non-well-behaving games and games with modified or removed video files.

Also did some refactoring of return values to bool as they were binary 0/-1.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/610 **Author:** [@roamic](https://github.com/roamic) **Created:** 8/27/2024 **Status:** ✅ Merged **Merged:** 8/27/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `avplayer-handle-init-errors` --- ### 📝 Commits (1) - [`2d354a0`](https://github.com/shadps4-emu/shadPS4/commit/2d354a095ae41cf58d72cf8ec88fffcd84dd4d68) AvPlayer: Handle Initialization errors ### 📊 Changes **8 files changed** (+90 additions, -61 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/avplayer/avplayer_data_streamer.h` (+3 -0) 📝 `src/core/libraries/avplayer/avplayer_file_streamer.cpp` (+17 -13) 📝 `src/core/libraries/avplayer/avplayer_file_streamer.h` (+3 -1) 📝 `src/core/libraries/avplayer/avplayer_impl.cpp` (+6 -3) 📝 `src/core/libraries/avplayer/avplayer_source.cpp` (+31 -23) 📝 `src/core/libraries/avplayer/avplayer_source.h` (+4 -4) 📝 `src/core/libraries/avplayer/avplayer_state.cpp` (+23 -14) 📝 `src/core/libraries/avplayer/avplayer_state.h` (+3 -3) </details> ### 📄 Description Replaced asserts during the initialization stage with error propagation. This fixes some non-well-behaving games and games with modified or removed video files. Also did some refactoring of return values to `bool` as they were binary 0/-1. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>