[PR #560] [MERGED] Fixed video dimensions alignment and image cache #1634

New issue

Closed

opened 2026-02-27 21:13:22 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:13:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/560
Author: @roamic
Created: 8/24/2024
Status: ✅ Merged
Merged: 8/24/2024
Merged by: @georgemoralis

Base: main ← Head: avplayer-and-texture-cache-fixes

📝 Commits (1)

41dec15 Fixed video dimensions alignment and image cache

📊 Changes

4 files changed (+48 additions, -14 deletions)

View changed files

📝 src/core/libraries/avplayer/avplayer.cpp (+3 -0)
📝 src/core/libraries/avplayer/avplayer_source.cpp (+41 -12)
📝 src/core/libraries/avplayer/avplayer_state.cpp (+4 -1)
📝 src/video_core/texture_cache/texture_cache.cpp (+0 -1)

📄 Description

AvPlayer:
The library should provide raw frames and ask user to remove the unused parts with crop offsets.
Since this library supports only AVX (H.264) video we may safely assume that frame buffer dimensions are aligned to 16. Unfortunately, I found no way to get raw frame buffers from ffmpeg, so the data is positioned in the memory manually.

Image cache:
The image should be erased only in DeleteImage instead of UnregisterImage.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/560 **Author:** [@roamic](https://github.com/roamic) **Created:** 8/24/2024 **Status:** ✅ Merged **Merged:** 8/24/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `avplayer-and-texture-cache-fixes` --- ### 📝 Commits (1) - [`41dec15`](https://github.com/shadps4-emu/shadPS4/commit/41dec15869d910a73384f56d35839e69b62d42e1) Fixed video dimensions alignment and image cache ### 📊 Changes **4 files changed** (+48 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/avplayer/avplayer.cpp` (+3 -0) 📝 `src/core/libraries/avplayer/avplayer_source.cpp` (+41 -12) 📝 `src/core/libraries/avplayer/avplayer_state.cpp` (+4 -1) 📝 `src/video_core/texture_cache/texture_cache.cpp` (+0 -1) </details> ### 📄 Description AvPlayer: The library should provide raw frames and ask user to remove the unused parts with crop offsets. Since this library supports only AVX (H.264) video we may safely assume that frame buffer dimensions are aligned to 16. Unfortunately, I found no way to get raw frame buffers from ffmpeg, so the data is positioned in the memory manually. Image cache: The image should be erased only in `DeleteImage` instead of `UnregisterImage`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>