[PR #546] [MERGED] cmake: fix version constraints #1626

New issue

Closed

opened 2026-02-27 21:13:20 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:13:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/546
Author: @abouvier
Created: 8/23/2024
Status: ✅ Merged
Merged: 8/23/2024
Merged by: @georgemoralis

Base: main ← Head: cmake-compat

📝 Commits (1)

a71d0d8 cmake: fix version constraints

📊 Changes

1 file changed (+7 additions, -4 deletions)

View changed files

📝 CMakeLists.txt (+7 -4)

📄 Description

Minimum versions required were raised for no reason in https://github.com/shadps4-emu/shadPS4/pull/228 but:

the project still build fine with fmt>=10.2.0 and zlib-ng>=2.1.7
the zydis commit in externals is from an unreleased dev branch (with an incompatible change) which will ultimately be v5, so v4 library need to be rejected
cryptopp is not always needed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/546 **Author:** [@abouvier](https://github.com/abouvier) **Created:** 8/23/2024 **Status:** ✅ Merged **Merged:** 8/23/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `cmake-compat` --- ### 📝 Commits (1) - [`a71d0d8`](https://github.com/shadps4-emu/shadPS4/commit/a71d0d8dbb2254dd1f40f131e8ca2bc1bd488221) cmake: fix version constraints ### 📊 Changes **1 file changed** (+7 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+7 -4) </details> ### 📄 Description Minimum versions required were raised for no reason in https://github.com/shadps4-emu/shadPS4/pull/228 but: - the project still build fine with `fmt>=10.2.0` and `zlib-ng>=2.1.7` - the `zydis` commit in externals is from an unreleased dev branch (with an incompatible change) which will ultimately be v5, so v4 library need to be rejected - `cryptopp` is not always needed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>