[PR #538] [MERGED] shader_recompiler: handle fetch shader address offsets #1621

New issue

Closed

opened 2026-02-27 21:13:19 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:13:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/538
Author: @viniciuslrangel
Created: 8/23/2024
Status: ✅ Merged
Merged: 8/24/2024
Merged by: @psucien

Base: main ← Head: offset_fetch_shaders

📝 Commits (4)

81f8c64 shader_recompiler: handle fetch shader address offsets
68f0420 shader_recompiler: fix fetch_shader when offset is not present
d9ea23b video_core: propagate index/offset SGPRs to vkCmdDraw instead of offsetting the buffer address
a5e468a video_core: add vertex_offset to non-indexed draw calls

📊 Changes

5 files changed (+53 additions, -9 deletions)

View changed files

📝 src/shader_recompiler/frontend/fetch_shader.cpp (+20 -4)
📝 src/shader_recompiler/frontend/fetch_shader.h (+7 -1)
📝 src/shader_recompiler/frontend/translate/translate.cpp (+5 -2)
📝 src/shader_recompiler/runtime_info.h (+15 -0)
📝 src/video_core/renderer_vulkan/vk_rasterizer.cpp (+6 -2)

📄 Description

parse vertex & instance offset sgpr from fetch shader and propagate them to vkCmdDraw

still need to handle inputs with OverStepRate

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/538 **Author:** [@viniciuslrangel](https://github.com/viniciuslrangel) **Created:** 8/23/2024 **Status:** ✅ Merged **Merged:** 8/24/2024 **Merged by:** [@psucien](https://github.com/psucien) **Base:** `main` ← **Head:** `offset_fetch_shaders` --- ### 📝 Commits (4) - [`81f8c64`](https://github.com/shadps4-emu/shadPS4/commit/81f8c642a6df4106d6cb289f2da677c90ea5671a) shader_recompiler: handle fetch shader address offsets - [`68f0420`](https://github.com/shadps4-emu/shadPS4/commit/68f042001c5b00544be13d6bede94151b6f6b69c) shader_recompiler: fix fetch_shader when offset is not present - [`d9ea23b`](https://github.com/shadps4-emu/shadPS4/commit/d9ea23badce5c6ab1f32cca0f72e2b591bb46659) video_core: propagate index/offset SGPRs to vkCmdDraw instead of offsetting the buffer address - [`a5e468a`](https://github.com/shadps4-emu/shadPS4/commit/a5e468af4793fb68f6a92da65e04a69bffcbbe37) video_core: add vertex_offset to non-indexed draw calls ### 📊 Changes **5 files changed** (+53 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/frontend/fetch_shader.cpp` (+20 -4) 📝 `src/shader_recompiler/frontend/fetch_shader.h` (+7 -1) 📝 `src/shader_recompiler/frontend/translate/translate.cpp` (+5 -2) 📝 `src/shader_recompiler/runtime_info.h` (+15 -0) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.cpp` (+6 -2) </details> ### 📄 Description parse vertex & instance offset sgpr from fetch shader and propagate them to vkCmdDraw still need to handle inputs with OverStepRate --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>