[PR #517] [MERGED] Misc fixes #1609

New issue

Closed

opened 2026-02-27 21:13:16 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:13:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/517
Author: @roamic
Created: 8/21/2024
Status: ✅ Merged
Merged: 8/21/2024
Merged by: @georgemoralis

Base: main ← Head: fix-stencil-validation-errors

📝 Commits (3)

cd75c4f Misc fixes
fa49346 Removed the skip for draw calls without RTs
1f8f9d7 Remove Srgb image stores to rework later

📊 Changes

10 files changed (+89 additions, -27 deletions)

View changed files

📝 src/core/libraries/avplayer/avplayer_source.cpp (+3 -0)
📝 src/core/libraries/system/msgdialog.cpp (+18 -3)
📝 src/video_core/amdgpu/liverpool.h (+1 -0)
📝 src/video_core/renderer_vulkan/liverpool_to_vk.cpp (+17 -11)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp (+1 -2)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.h (+1 -0)
📝 src/video_core/renderer_vulkan/vk_pipeline_cache.cpp (+16 -1)
📝 src/video_core/renderer_vulkan/vk_rasterizer.cpp (+11 -4)
📝 src/video_core/renderer_vulkan/vk_scheduler.cpp (+10 -3)
📝 src/video_core/texture_cache/image.cpp (+11 -3)

📄 Description

Fixed hanging subtitles after video has finished playing by reporting 0 in sceAvPlayerCurrentTime
Fixed a crash in sceMsgDialogOpen (used in Resident Evil 4)
Fixed Depth/Stencil usage. Fixes most of the validation errors that mention depth/stencil buffer usage
Set W/H of renderArea to 1 to suppress validation errors for draw calls that do not use any render targets.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/517 **Author:** [@roamic](https://github.com/roamic) **Created:** 8/21/2024 **Status:** ✅ Merged **Merged:** 8/21/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `fix-stencil-validation-errors` --- ### 📝 Commits (3) - [`cd75c4f`](https://github.com/shadps4-emu/shadPS4/commit/cd75c4f1a26830dc14396dc8fa25fab54ee725fc) Misc fixes - [`fa49346`](https://github.com/shadps4-emu/shadPS4/commit/fa4934686abf097772a7f546da7c95c6b9466cbf) Removed the skip for draw calls without RTs - [`1f8f9d7`](https://github.com/shadps4-emu/shadPS4/commit/1f8f9d764c972d7900bcebcc6875ef0cf7038ffb) Remove Srgb image stores to rework later ### 📊 Changes **10 files changed** (+89 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/avplayer/avplayer_source.cpp` (+3 -0) 📝 `src/core/libraries/system/msgdialog.cpp` (+18 -3) 📝 `src/video_core/amdgpu/liverpool.h` (+1 -0) 📝 `src/video_core/renderer_vulkan/liverpool_to_vk.cpp` (+17 -11) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp` (+1 -2) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.h` (+1 -0) 📝 `src/video_core/renderer_vulkan/vk_pipeline_cache.cpp` (+16 -1) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.cpp` (+11 -4) 📝 `src/video_core/renderer_vulkan/vk_scheduler.cpp` (+10 -3) 📝 `src/video_core/texture_cache/image.cpp` (+11 -3) </details> ### 📄 Description * Fixed hanging subtitles after video has finished playing by reporting 0 in `sceAvPlayerCurrentTime` * Fixed a crash in `sceMsgDialogOpen` (used in Resident Evil 4) * Fixed Depth/Stencil usage. Fixes most of the validation errors that mention depth/stencil buffer usage * Set W/H of `renderArea` to `1` to suppress validation errors for draw calls that do not use any render targets. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>