[PR #514] [MERGED] Fix a few issues with the intel anv vulkan driver from mesa #1608

New issue

Closed

opened 2026-02-27 21:13:16 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:13:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/514
Author: @Random06457
Created: 8/21/2024
Status: ✅ Merged
Merged: 8/24/2024
Merged by: @psucien

Base: main ← Head: intel_fixes

📝 Commits (2)

358a049 add fallback format for d16UnormS8Uint which is not supported by intel
05f551b fix depth/stencil buffer creation issues causing asserts in intel driver

📊 Changes

4 files changed (+11 additions, -6 deletions)

View changed files

📝 src/video_core/renderer_vulkan/liverpool_to_vk.cpp (+1 -0)
📝 src/video_core/renderer_vulkan/vk_instance.cpp (+2 -0)
📝 src/video_core/texture_cache/image.cpp (+7 -6)
📝 src/video_core/texture_cache/texture_cache.cpp (+1 -0)

📄 Description

intel doesn't support VK_FORMAT_D16_UNORM_S8_UINT, so use VK_FORMAT_D24_UNORM_S8_UINT instead.
the drivers panics when a texture has usage & VK_IMAGE_USAGE_STORAGE_BIT && aspect == VK_IMAGE_ASPECT_DEPTH_BIT (https://gitlab.freedesktop.org/mesa/mesa/-/blob/main/src/intel/vulkan/anv_image.c#L760)
TextureCache::FindDepthTarget wasn't setting the image.aspect_mask of the depth image properly so it still had its default value VK_IMAGE_ASPECT_COLOR_BIT which causes this assert to trigger: https://gitlab.freedesktop.org/mesa/mesa/-/blob/main/src/vulkan/runtime/vk_image.c#L279

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/514 **Author:** [@Random06457](https://github.com/Random06457) **Created:** 8/21/2024 **Status:** ✅ Merged **Merged:** 8/24/2024 **Merged by:** [@psucien](https://github.com/psucien) **Base:** `main` ← **Head:** `intel_fixes` --- ### 📝 Commits (2) - [`358a049`](https://github.com/shadps4-emu/shadPS4/commit/358a049565d6a905cf657fd2121e6a122d6e979c) add fallback format for d16UnormS8Uint which is not supported by intel - [`05f551b`](https://github.com/shadps4-emu/shadPS4/commit/05f551b895355f83be5feb6f0d23ace4615e49f1) fix depth/stencil buffer creation issues causing asserts in intel driver ### 📊 Changes **4 files changed** (+11 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/liverpool_to_vk.cpp` (+1 -0) 📝 `src/video_core/renderer_vulkan/vk_instance.cpp` (+2 -0) 📝 `src/video_core/texture_cache/image.cpp` (+7 -6) 📝 `src/video_core/texture_cache/texture_cache.cpp` (+1 -0) </details> ### 📄 Description - intel doesn't support `VK_FORMAT_D16_UNORM_S8_UINT`, so use `VK_FORMAT_D24_UNORM_S8_UINT` instead. - the drivers panics when a texture has `usage & VK_IMAGE_USAGE_STORAGE_BIT && aspect == VK_IMAGE_ASPECT_DEPTH_BIT` (https://gitlab.freedesktop.org/mesa/mesa/-/blob/main/src/intel/vulkan/anv_image.c#L760) - `TextureCache::FindDepthTarget` wasn't setting the `image.aspect_mask` of the depth image properly so it still had its default value `VK_IMAGE_ASPECT_COLOR_BIT` which causes this assert to trigger: https://gitlab.freedesktop.org/mesa/mesa/-/blob/main/src/vulkan/runtime/vk_image.c#L279 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>