[PR #502] [MERGED] Workaround for readonly memory mapping of files issue #1599

Closed
opened 2026-02-27 21:13:14 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/502
Author: @Borchev
Created: 8/20/2024
Status: Merged
Merged: 8/22/2024
Merged by: @georgemoralis

Base: mainHead: ROMappedFileWorkaround


📝 Commits (2)

  • 6596fe0 Workaround for readonly memory mapping of files issue
  • fc300b5 Fix unmapping bug

📊 Changes

4 files changed (+26 additions, -12 deletions)

View changed files

📝 src/common/io_file.cpp (+2 -3)
📝 src/core/address_space.cpp (+21 -7)
📝 src/core/address_space.h (+1 -1)
📝 src/core/memory.cpp (+2 -1)

📄 Description

Potential solution/workaround for #369. Fixes Cuphead crash on boot.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/502 **Author:** [@Borchev](https://github.com/Borchev) **Created:** 8/20/2024 **Status:** ✅ Merged **Merged:** 8/22/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `ROMappedFileWorkaround` --- ### 📝 Commits (2) - [`6596fe0`](https://github.com/shadps4-emu/shadPS4/commit/6596fe091c3e69e206b277b4adfd5c177eec5f56) Workaround for readonly memory mapping of files issue - [`fc300b5`](https://github.com/shadps4-emu/shadPS4/commit/fc300b526561a2d57cb69a4442c24d4c532bb4cc) Fix unmapping bug ### 📊 Changes **4 files changed** (+26 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/common/io_file.cpp` (+2 -3) 📝 `src/core/address_space.cpp` (+21 -7) 📝 `src/core/address_space.h` (+1 -1) 📝 `src/core/memory.cpp` (+2 -1) </details> ### 📄 Description Potential solution/workaround for #369. Fixes Cuphead crash on boot. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 21:13:14 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#1599
No description provided.