[PR #481] [MERGED] Set game window size based on the config (in windowed mode) #1591

New issue

Closed

opened 2026-02-27 21:13:11 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:13:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/481
Author: @kotn3l
Created: 8/19/2024
Status: ✅ Merged
Merged: 8/20/2024
Merged by: @georgemoralis

Base: main ← Head: main

📝 Commits (4)

dc3dd32 Set windowed mode size based on config
a3e5aa1 fix formatting oops
630212c emulator.cpp clang format fix (hopefully?)
d0bb5c0 formatting fix for real

📊 Changes

1 file changed (+2 additions, -5 deletions)

View changed files

📝 src/emulator.cpp (+2 -5)

📄 Description

Changing the width and height in the emulator config didn't affect the game window size (in non-fullscreen mode). This little PR changes that.

I don't actually know what resolution the games render at, so this might be an issue -- please let me know below. (I guess the games have the info on what resolution to render at for both PS4 and Pro?)

A possible next step would be to make the window properly resizeable, and then just do a basic scaling on the framebuffer based on it, while maintaining aspect ratio.

EDIT: same for fullscreen mode -- for example, I have an ultrawide monitor, and usiong fullscreen mode just stretches the framebuffer.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/481 **Author:** [@kotn3l](https://github.com/kotn3l) **Created:** 8/19/2024 **Status:** ✅ Merged **Merged:** 8/20/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (4) - [`dc3dd32`](https://github.com/shadps4-emu/shadPS4/commit/dc3dd3263615d772b79077c420a5386042f17dbd) Set windowed mode size based on config - [`a3e5aa1`](https://github.com/shadps4-emu/shadPS4/commit/a3e5aa1372221ba2870d62044620820ec75d76ec) fix formatting oops - [`630212c`](https://github.com/shadps4-emu/shadPS4/commit/630212cf26b9e6dfb654354b685ec39b1c00b112) emulator.cpp clang format fix (hopefully?) - [`d0bb5c0`](https://github.com/shadps4-emu/shadPS4/commit/d0bb5c03c8b5538c316252512ad6253eea8a223d) formatting fix for real ### 📊 Changes **1 file changed** (+2 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/emulator.cpp` (+2 -5) </details> ### 📄 Description Changing the width and height in the emulator config didn't affect the game window size (in non-fullscreen mode). This little PR changes that. I don't actually know what resolution the games render at, so this might be an issue -- please let me know below. (I guess the games have the info on what resolution to render at for both PS4 and Pro?) A possible next step would be to make the window properly resizeable, and then just do a basic scaling on the framebuffer based on it, while maintaining aspect ratio. EDIT: same for fullscreen mode -- for example, I have an ultrawide monitor, and usiong fullscreen mode just stretches the framebuffer. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>