[PR #453] [MERGED] gpu: check right register for primitive restart index #1574

New issue

Closed

opened 2026-02-27 21:13:08 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:13:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/453
Author: @viniciuslrangel
Created: 8/16/2024
Status: ✅ Merged
Merged: 8/16/2024
Merged by: @raphaelthegreat

Base: main ← Head: fix_reg_primitive_restart_index

📝 Commits (1)

7feada6 gpu: check right register for primitive restart index

📊 Changes

4 files changed (+13 additions, -8 deletions)

View changed files

📝 src/video_core/amdgpu/liverpool.h (+6 -3)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp (+3 -3)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.h (+2 -1)
📝 src/video_core/renderer_vulkan/vk_pipeline_cache.cpp (+2 -1)

📄 Description

@reg-prig suggestion

Not sure if it is possible to have trash in the register (maybe if primitive restart is toggled off), but just to make sure.

Related to #438

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/453 **Author:** [@viniciuslrangel](https://github.com/viniciuslrangel) **Created:** 8/16/2024 **Status:** ✅ Merged **Merged:** 8/16/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `fix_reg_primitive_restart_index` --- ### 📝 Commits (1) - [`7feada6`](https://github.com/shadps4-emu/shadPS4/commit/7feada6cc556d3efe2ca284736fbdb0416f45307) gpu: check right register for primitive restart index ### 📊 Changes **4 files changed** (+13 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/amdgpu/liverpool.h` (+6 -3) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp` (+3 -3) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.h` (+2 -1) 📝 `src/video_core/renderer_vulkan/vk_pipeline_cache.cpp` (+2 -1) </details> ### 📄 Description @reg-prig suggestion Not sure if it is possible to have trash in the register (maybe if primitive restart is toggled off), but just to make sure. Related to #438 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>