[PR #420] [MERGED] Fix some Vulkan validation errors on macOS. #1550

New issue

Closed

opened 2026-02-27 21:13:01 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:13:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/420
Author: @squidbus
Created: 8/12/2024
Status: ✅ Merged
Merged: 8/13/2024
Merged by: @raphaelthegreat

Base: main ← Head: macos-validation

📝 Commits (1)

519e384 Fix some Vulkan validation errors on macOS.

📊 Changes

3 files changed (+42 additions, -4 deletions)

View changed files

📝 src/video_core/renderer_vulkan/vk_instance.cpp (+24 -3)
📝 src/video_core/renderer_vulkan/vk_platform.cpp (+7 -0)
📝 src/video_core/renderer_vulkan/vk_swapchain.cpp (+11 -1)

📄 Description

Set up portability extension requirements to allow using the standard Vulkan loader on macOS, which in turn allows loading validation layers.
Fix some validation errors for unsupported extensions in the device structure chain.
Fix using mailbox present mode when unsupported, which was also causing frame pacing issues on macOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/420 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 8/12/2024 **Status:** ✅ Merged **Merged:** 8/13/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `macos-validation` --- ### 📝 Commits (1) - [`519e384`](https://github.com/shadps4-emu/shadPS4/commit/519e384049a42002abdacf20148c9d2d25ac98e6) Fix some Vulkan validation errors on macOS. ### 📊 Changes **3 files changed** (+42 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/vk_instance.cpp` (+24 -3) 📝 `src/video_core/renderer_vulkan/vk_platform.cpp` (+7 -0) 📝 `src/video_core/renderer_vulkan/vk_swapchain.cpp` (+11 -1) </details> ### 📄 Description * Set up portability extension requirements to allow using the standard Vulkan loader on macOS, which in turn allows loading validation layers. * Fix some validation errors for unsupported extensions in the device structure chain. * Fix using mailbox present mode when unsupported, which was also causing frame pacing issues on macOS. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>